feat: initial implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/initial-implementation
branch
4 times, most recently
from
8cc4cf9 to
172e4e5
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
172e4e5 to
cb51a9c
Compare
1 task
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 90.00%
=======================================
Files ? 2
Lines ? 40
Branches ? 0
=======================================
Hits ? 36
Misses ? 4
Partials ? 0 Continue to review full report at Codecov.
|
2 tasks
Owner
Author
|
cc @jacobheun cannot ask you direct review |
jacobheun
approved these changes
Oct 13, 2020
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
LGTM, just a minor thing in the readme.
README.md
Outdated
|
|
||
| Use Node.js' dns promises API if available. | ||
| ```js | ||
| const { Resolver } = require('dns').promises || require('dns-over-http-resolver') |
There was a problem hiding this comment.
This example isn't going to work. I'd just specify that users can use require('dns').promises in Node.js in lieu of this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the
dns-over-http-resolverwith theresolvemethodNeeds: