feat: resolve multiaddrs #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/resolve-multiaddrs
branch
from
653f468 to
569923c
Compare
vasco-santos
force-pushed
the
feat/resolve-multiaddrs
branch
from
a944939 to
5957d95
Compare
2 tasks
jacobheun
reviewed
Oct 13, 2020
vasco-santos
force-pushed
the
feat/resolve-multiaddrs
branch
from
aae492f to
abf681d
Compare
vasco-santos
force-pushed
the
feat/resolve-multiaddrs
branch
from
abf681d to
eeb5822
Compare
jacobheun
approved these changes
Oct 27, 2020
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
LGTM, just some minor suggestions.
Co-authored-by: Jacob Heun <[email protected]>
Member
Author
|
remaining comments addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the resolve API method to multiaddr, as well as a custom resolver for
dnsaddrthatmultiaddrusers can rely on. Further custom resolvers includingdns4anddns6should be added to this repo.Needs:
Closes #94