Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGMD Pro link-out missing in the vue interface #1632

Closed
stolpeo opened this issue May 16, 2024 · 1 comment · Fixed by #1677
Closed

HGMD Pro link-out missing in the vue interface #1632

stolpeo opened this issue May 16, 2024 · 1 comment · Fixed by #1677
Assignees
Labels
enhancement New feature or request

Comments

@stolpeo
Copy link
Contributor

stolpeo commented May 16, 2024

Is your feature request related to a problem? Please describe.
The HGMD Pro link-out can be enabled in the configuration and configured with a custom URL, but this is never used. Likely it was implemented in the old interface, but didn't make it to the new one, as mentioned in #739.

VARFISH_ENABLE_HGMD_PRO_LINKOUT = env.bool("VARFISH_ENABLE_HGMD_PRO_LINKOUT", default=False)

We need to either implement the link-out or discuss the usage. It was briefly mentioned in the meeting today, but I can't recall if we had any solution.

@stolpeo stolpeo added the enhancement New feature or request label May 16, 2024
@xiamaz
Copy link
Collaborator

xiamaz commented May 30, 2024

After discussion, this configuration option should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants