Skip to content

Conversation

@andjsrk
Copy link
Contributor

@andjsrk andjsrk commented Mar 13, 2025

Currently, the definition of ClassNames is recursive:

export type ClassNames = string | Array<ClassNames>;

But it is not handled correctly on:
for (const rule of rules) {
if (typeof rule === 'string') {
classList.push(rule);
} else {
styleRules.push(rule);
}
}

This PR fixes this mismatch.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: a95d74b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@vanilla-extract/css Patch
@vanilla-extract/compiler Patch
@vanilla-extract/integration Patch
@vanilla-extract/rollup-plugin Patch
@vanilla-extract/vite-plugin Patch
@vanilla-extract/esbuild-plugin Patch
@vanilla-extract/jest-transform Patch
@vanilla-extract/parcel-transformer Patch
@vanilla-extract/webpack-plugin Patch
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

andjsrk added 2 commits March 13, 2025 16:10
`dudupeAndJoinClassList(classList)` is on below and will handle `ClassNames`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant