Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestHostClientMaxConnWaitTimeoutError test case sometimes fails #1832

Conversation

newacorn
Copy link
Contributor

The current implementation makes some incorrect assumptions about observing changes in the state of wantConn.

The following two pull requests failed the GitHub workflow named test due to the TestHostClientMaxConnWaitTimeoutError test case.
#1818
#1829

Of course, we don't need to guarantee that the return value of HostClient.connsWait.len() is zero when all client calls have exited, because this doesn't affect the correctness of the program in the same way as the HostClient.MaxConns field does.

There is a test in the suite, TestHostClientMaxConnWaitTimeoutError, which can cause the test to fail under certain conditions. We either need to remove this test or find a way to fix it. Additionally, false waiters could slightly impact the number of iterations in the loop during handle MaxConns semaphore in the HostClient.releaseConn method.

This fix should resolve the issue.
The reason for the failure of this test case is related to the issue described in #1830.

The current implementation makes some incorrect assumptions about observing changes in the state of wantConn.
@erikdubbelboer erikdubbelboer merged commit 3cdc6f1 into valyala:master Aug 20, 2024
19 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants