Make RetryIfFunc handle request errors #1818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1744
To maintain compatibility with the previous
RetryIfFunc
as much as possible, I think it can be relaxed into aninterface{}
type.I believe that directly adding an extra field might confuse developers.
If we were to directly use generics introduced in Go 1.18 for type constraints, it would involve too many changes.
I think the most balanced approach for now is to handle it using interface{} and type assertion.