Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timepicker): at Disabled Timepicker example input fields are highlighted after click, even if they are disabled #3371

Closed
YevheniiaMazur opened this issue Dec 28, 2017 · 0 comments
Closed

fix(timepicker): at Disabled Timepicker example input fields are highlighted after click, even if they are disabled #3371

YevheniiaMazur opened this issue Dec 28, 2017 · 0 comments
Labels
comp(demo) comp(timepicker) issue prio: medium

Comments

@YevheniiaMazur
Copy link

YevheniiaMazur commented Dec 28, 2017 •
edited
Loading

Bug description:

  • Go to Timepicker demo page
  • Scroll down to Disabled example
  • Click on Enable/Disable input to make input fields disabled
  • Click on hour or minute disabled field

Expected result

Disabled input fields don't have highlighting

timepickerdisabledissue 1

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: all supported
Angular: all supported
Bootstrap: all supported
@artolshansky artolshansky mentioned this issue Jan 17, 2018
Closed
35 tasks
@EvilAlexei EvilAlexei self-assigned this Jan 25, 2018
@EvilAlexei EvilAlexei removed their assignment Jan 25, 2018
@EvilAlexei EvilAlexei changed the title fix(demo timepicker): at Disabled Timepicker example input fields are highlighted after click, even if they are disabled fix(timepicker): at Disabled Timepicker example input fields are highlighted after click, even if they are disabled Jan 31, 2018
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 1, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
3e5fc5a 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
@IraErshova IraErshova mentioned this issue Feb 1, 2018
Merged
5 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 1, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
61f76d7 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 1, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
1459aea 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 7, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
5bd0fad 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 7, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
d7ad6cd 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 8, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
22db077 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 13, 2018
@IraErshova
feat(timepicker): Add ability to set readonly/disabled state valor-so…
cb50a42 
…ftware#3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close valor-software#3602 valor-software#3371
valorkin pushed a commit that referenced this issue Mar 1, 2018
@IraErshova @valorkin
feat(timepicker): Add ability to set readonly/disabled state #3602 (#…
4e5f828 
…3611)

* feat(timepicker): add validation for timepicker

Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close #3549 #3288

* feat(timepicker): Add ability to set readonly/disabled state #3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close #3602 #3371
@Domainv Domainv closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(demo) comp(timepicker) issue prio: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EvilAlexei @Domainv @YevheniiaMazur