Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(timepicker): Min-max demo example. When user once choose unavailable PM time, AM/PM button stops working #3288

Closed
YevheniiaMazur opened this issue Dec 14, 2017 · 2 comments
Closed

docs(timepicker): Min-max demo example. When user once choose unavailable PM time, AM/PM button stops working #3288

YevheniiaMazur opened this issue Dec 14, 2017 · 2 comments
Labels
comp(demo) comp(timepicker) issue prio: medium

Comments

@YevheniiaMazur
Copy link

YevheniiaMazur commented Dec 14, 2017 •
edited
Loading

Bug description

  • Go to Timepicker demo page
  • Scroll to Min-Max example
  • Enter time more then 5 hours and click AM/PM button for choosing this PM unavailable time
  • Click on AM/PM button one more time

Expected result:

AM/PM button is working for available choosen time

minmaxissue

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 2.0.0-beta.11 and older versions

Angular: all supported

Bootstrap: 3rd and 4th
@EvilAlexei EvilAlexei self-assigned this Jan 12, 2018
@EvilAlexei EvilAlexei removed their assignment Jan 15, 2018
@artolshansky artolshansky mentioned this issue Jan 17, 2018
Closed
35 tasks
@Isirak98
Copy link

An added problem to this issue, is that you can manually edit the fields to invalid values and the picker will still accept them.

Steps to recreate:

  1. Go to the Min - Max section of the Demo page
  2. Use the spinners to navigate to the minimum value, 8:00 AM.
  3. Type in 7 in the hour field, which results in the time being 7:00 AM The time picker accepts the value.

I do suspect the issue is the same with the minute section as well.

@EvilAlexei EvilAlexei self-assigned this Jan 25, 2018
@EvilAlexei EvilAlexei removed their assignment Jan 25, 2018
@EvilAlexei EvilAlexei self-assigned this Jan 25, 2018
@EvilAlexei EvilAlexei removed their assignment Jan 25, 2018
@EvilAlexei EvilAlexei changed the title fix(timepicker demo): Min-max demo example. When user once choose unavailable PM time, AM/PM button stops working docs(timepicker): Min-max demo example. When user once choose unavailable PM time, AM/PM button stops working Jan 29, 2018
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 30, 2018
@IraErshova
feat(timepicker): add validation for timepicker
a3a4cb6 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
@IraErshova IraErshova mentioned this issue Jan 30, 2018
Merged
3 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 31, 2018
@IraErshova
feat(timepicker): add validation for timepicker
fc3c394 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 7, 2018
@IraErshova
feat(timepicker): add validation for timepicker
200e8f9 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 8, 2018
@IraErshova
feat(timepicker): add validation for timepicker
23451f4 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Mar 1, 2018
@IraErshova
feat(timepicker): add validation for timepicker
3c36269 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
valorkin pushed a commit that referenced this issue Mar 1, 2018
@IraErshova @valorkin
feat(timepicker): Add ability to set readonly/disabled state #3602 (#…
4e5f828 
…3611)

* feat(timepicker): add validation for timepicker

Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close #3549 #3288

* feat(timepicker): Add ability to set readonly/disabled state #3602

Add ability to set readonly/disabled state
Add disabled demo
Fix bud related to highlight input in readonly mood
Extend test for timepicker

Close #3602 #3371
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Mar 10, 2018
@IraErshova
feat(timepicker): add validation for timepicker
e5ffded 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Mar 11, 2018
@IraErshova
feat(timepicker): add validation for timepicker
99ef537 
Add validation for timepicker based on ui-bootstrap validation.
Fix min-max validation issue.

close valor-software#3549 valor-software#3288
valorkin pushed a commit that referenced this issue Mar 29, 2018
@IraErshova @valorkin
feat(timepicker): add validation for timepicker (#3588)
d8ee1f8 
Add validation for timepicker based on jquery-ui validation.
Fix min-max validation issue.

close #3549 #3288
@ludmilanesvitiy
Copy link
Contributor

Issue resolved: https://valor-software.com/ngx-bootstrap/#/timepicker#min-max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(demo) comp(timepicker) issue prio: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EvilAlexei @ludmilanesvitiy @YevheniiaMazur @Isirak98