Skip to content

Pass network_id to precomputeDelegationPir #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg0x merged 2 commits into from
May 1, 2026
Merged

Pass network_id to precomputeDelegationPir #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1734681
Pass network_id to precomputeDelegationPir
greg0x May 1, 2026
edd1e71
Bump zcash_voting to 0.3.0
greg0x May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ rust_decimal = { version = "1", default-features = false, features = ["c-repr"]
# - The "static" feature is required for the "compression" default feature of arti-client.
xz2 = { version = "0.1", features = ["static"] }

zcash_voting = "0.2.3"
zcash_voting = "0.3.0"
voting-circuits = { version = "0.4.1", features = ["share-reveal"] }
zcash_keys = { version = "0.13", features = ["orchard"] }
incrementalmerkletree = { version = "0.8", default-features = false }
Expand Down
4 changes: 3 additions & 1 deletion Sources/ZcashLightClientKit/Rust/Voting/VotingRustBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ extension VotingRustBackend {
notes: [VotingNoteInfo],
pirEndpoints: [String],
expectedSnapshotHeight: UInt64,
networkId: UInt32,
pirResolver: PirSnapshotResolver = PirSnapshotResolver()
) async throws -> VotingDelegationPirPrecomputeResult {
let pirServerUrl = try await pirResolver.resolve(
Expand All @@ -572,7 +573,8 @@ extension VotingRustBackend {
notesBuf.baseAddress,
UInt(notesBuf.count),
urlBuf.baseAddress,
UInt(urlBuf.count)
UInt(urlBuf.count),
networkId
)
}
}
Expand Down
9 changes: 8 additions & 1 deletion rust/src/voting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,6 +1454,7 @@ pub unsafe extern "C" fn zcashlc_voting_precompute_delegation_pir(
notes_json_len: usize,
pir_server_url: *const u8,
pir_server_url_len: usize,
network_id: u32,
) -> *mut crate::ffi::BoxedSlice {
let db = AssertUnwindSafe(db);
let res = catch_panic(|| {
Expand All @@ -1467,7 +1468,13 @@ pub unsafe extern "C" fn zcashlc_voting_precompute_delegation_pir(

let result = handle
.db
.precompute_delegation_pir(&round_id_str, bundle_index, &core_notes, &pir_url)
.precompute_delegation_pir(
&round_id_str,
bundle_index,
&core_notes,
&pir_url,
network_id,
)
.map_err(|e| anyhow!("precompute_delegation_pir failed: {}", e))?;

let json_result: JsonDelegationPirPrecomputeResult = result.into();
Expand Down
Loading