Pass network_id to precomputeDelegationPir#36
Merged
Conversation
The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers).
greg0x
force-pushed
the
greg/precompute-network-id
branch
from
a5fa6de to
65f5355
Compare
Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
greg0x
force-pushed
the
greg/precompute-network-id
branch
from
65f5355 to
edd1e71
Compare
greg0x
changed the title
greg0x
added a commit
that referenced
this pull request
May 1, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
p0mvn
pushed a commit
that referenced
this pull request
May 3, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
p0mvn
pushed a commit
that referenced
this pull request
May 4, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
p0mvn
pushed a commit
that referenced
this pull request
May 5, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
p0mvn
pushed a commit
that referenced
this pull request
May 5, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
p0mvn
pushed a commit
that referenced
this pull request
May 5, 2026
* Pass network_id to precomputeDelegationPir The Rust-side fix (zcash_voting precompute keying IMT cache off circuit padded nullifiers) needs the FVK to derive those nullifiers, which means decoding each note's UFVK string. UFVK decode requires a network. Add network_id to the FFI signature and the Swift wrapper; the iOS side already passes networkId at the call site. Depends on: zcash_voting fix (greg/circuit-padded-nullifiers). * Bump zcash_voting to 0.3.0 Picks up the precompute_delegation_pir IMT-cache fix (circuit-side 0-zat padded nullifiers). Won't build until zcash_voting 0.2.4 is published — release commit for the upstream crate is in valargroup/zcash_voting#TBD. Bump zcash_voting to 0.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Unblocked:
zcash_voting 0.3.0is published on crates.io, and this PR'sCargo.locknow resolves that published crate/checksum.Summary
Companion to valargroup/zcash_voting#32. The upstream change adds the
network_idparameter needed by delegation PIR precompute when deriving padded-slot nullifiers from UFVK-backed note metadata.This PR plumbs
network_idthrough:zcashlc_voting_precompute_delegation_pirFFI signature (Rust, +1u32param)VotingRustBackend.precomputeDelegationPirSwift wrapper (+1UInt32param)It also updates the Rust dependency from
zcash_voting = "0.2.3"to"0.3.0"and refreshesCargo.lockagainst the published crates.io release.Verification
cargo check --libStacked on
zcash_voting 0.3.0)Consumed by
networkIdat the call site)