Throttle updates to N FPS (e.g. 60)? #212
Comments
|
Agree, would be a good improvement. |
|
Released Will keep this issue open until new reconciler and renderer becomes a default one. |
…19866) * perf(gatsby-cli): throttle progress bar, build significantly faster this way This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max. This drops the govbook benchmark from 210 seconds down to 140 seconds. Fixes #15505 Fixes #17452 Fixes #17966 Fixes #18801 Relates to #17873 Relates to vadimdemedes/ink#212 * Force flush on done() and use local var for total
…#19866) * perf(gatsby-cli): throttle progress bar, build significantly faster this way This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max. This drops the govbook benchmark from 210 seconds down to 140 seconds. Fixes #15505 Fixes #17452 Fixes #17966 Fixes #18801 Relates to #17873 Relates to vadimdemedes/ink#212 * Force flush on done() and use local var for total
|
I gave it a try and it definitely helped (70s runtime instead of 240s). Though it's still faster to manually batch updates at 30fps (40s instead of 70s). It would be perfect if we could set the fps ourselves. 60fps is too much IMO as a default. 60fps is needed for smooth animations and I'd say that most CLIs don't need smooth animations. |
|
Yeah, good suggestion. I'll try lowering it to 30fps. I'm not sure ability to customize fps would be a good move, because it's more of avoiding the root cause of a problem, rather than properly fixing it. For example, a progress bar component might be implemented to refresh every 100ms, when 1s would be more than enough. One thing I wanted to do for a while that could help performance a lot is avoiding rerendering layout when underlying React components didn't change (#21). |
|
Ink 3 is out with the fix for this issue included! Read the full announcement at https://vadimdemedes.com/posts/ink-3 :) |
…#19866) * perf(gatsby-cli): throttle progress bar, build significantly faster this way This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max. This drops the govbook benchmark from 210 seconds down to 140 seconds. Fixes #15505 Fixes #17452 Fixes #17966 Fixes #18801 Relates to #17873 Relates to vadimdemedes/ink#212 * Force flush on done() and use local var for total
Given Ink has to update the entire screen — it might be nice to throttle updates globally to e.g. 60 FPS. We're seeing some issues in Gatsby like gatsbyjs/gatsby#15505 that we can fix case by case but a global render throttle seems useful to explore.
The text was updated successfully, but these errors were encountered: