Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby compilation much Slower with ink than yurnalist's logger #18801

Closed
simonjoom opened this issue Oct 18, 2019 · 1 comment · Fixed by #19866
Closed

Gatsby compilation much Slower with ink than yurnalist's logger #18801

simonjoom opened this issue Oct 18, 2019 · 1 comment · Fixed by #19866

Comments

@simonjoom
Copy link

simonjoom commented Oct 18, 2019

I have got a big application to build with gatsby,

i constated a build much more slower still i ve got updated my gatsby, (it's not related to the last version but the logger to use), i found out that the cause is the logger

I checked that if i force gatsby to use the logger yurnalist instead by default Ink that gatsby-cli select, my application build in 30sec less time!

AS well in all my scrappy code i use lot of console.log that slow down the logger and the time spent to build... ok certainly console.log is not the best way to log, but everybody use that.

Certainly will be great to check and benchmark that as a build time is important for an user, maybe put in default yurnalist?

@sidharthachatterjee
Copy link
Contributor

Hello! This is a known issue and is being tracked in #15505

Let's continue the conversation there. Closing this for now! Thank you for opening nonetheless.

pvdz added a commit that referenced this issue Nov 28, 2019
…his way

This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max.

This drops the govbook benchmark from 210 seconds down to 140 seconds.

Fixes #15505
Fixes #17452
Fixes #17966
Fixes #18801

Relates to #17873
Relates to vadimdemedes/ink#212
gatsbybot pushed a commit that referenced this issue Nov 28, 2019
…19866)

* perf(gatsby-cli): throttle progress bar, build significantly faster this way

This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max.

This drops the govbook benchmark from 210 seconds down to 140 seconds.

Fixes #15505
Fixes #17452
Fixes #17966
Fixes #18801

Relates to #17873
Relates to vadimdemedes/ink#212

* Force flush on done() and use local var for total
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants