fix: fix Material combo box overlay sizing #8619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now sure if / how to add tests for this. Unit tests usually use Lumo styles, visual tests can't cover the loading animation. I figure it's not very relevant either with Material being deprecated. |
web-padawan
approved these changes
Feb 3, 2025
sissbruecker
force-pushed
the
fix/material-combo-box-overlay-sizing
branch
from
b36ca56 to
8a7bdce
Compare
sissbruecker
force-pushed
the
fix/material-combo-box-overlay-sizing
branch
from
8a7bdce to
65501cf
Compare
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
sissbruecker
added a commit
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Material theme for combo box uses
overflow: visibleon the overlay part to allow showing the loading indicator, which is positioned upwards to cover the field's bottom border (added in vaadin/vaadin-combo-box#743). However this causes the overlay sizing logic to break, which apparently needsoverflow: auto.This fixes the styles to only apply
overflow: visiblewhen the combo box is actually loading. That should be fine as the combo box is empty in that state and the overlay sizing logic is not (as) relevant.Before:
before.mov
After:
after.mov
Fixes vaadin/flow-components#7063
Type of change