-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add loader part and style loading items state #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @platosha)
demo/combo-box-basic-demos.html, line 95 at r1 (raw file):
xhr.onload = function() { const response = JSON.parse(xhr.responseText); setTimeout(() => {
Demos must be in ES5 so they work with IE11
theme/lumo/vaadin-combo-box-dropdown-styles.html, line 46 at r1 (raw file):
width: var(--lumo-icon-size-s); height: var(--lumo-icon-size-s); position: fixed;
Can't use fixed because it works differently on IE11
8e5f551
to
f896901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
demo/combo-box-basic-demos.html, line 95 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Demos must be in ES5 so they work with IE11
Done.
theme/lumo/vaadin-combo-box-dropdown-styles.html, line 46 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Can't use fixed because it works differently on IE11
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #710
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)