Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix identity manager Visual tests and add to the list #16

Merged
merged 36 commits into from
Feb 3, 2025
Merged

Conversation

manolo
Copy link
Member

@manolo manolo commented Jan 29, 2025

In this PR there are many changes, but main are:

  • It adds the --cluster= option so as kind is not needed if you have a valid cluster.
    for instance you can enable kubernetes in your Docker Desktop and run the script
    ./scripts/pit/run.sh --starters=control-center --cluster=docker-desktop
  • It fixes and enables visual tests for the cc-localization.js test
  • It fixes other issues regarding timeouts and elements in UI not yet present
  • It fixes certs for added apps

Tips to run the script:

  • Docker desktop needs to be installed and running, as well as helm and kind. k9s is recommended if you want to see in a separated how resources in cluster are deployed
  • Run the entire script installing a new kind cluster:
./scripts/pit/run.sh --starters=control-center
  • Run script but seeing what happens in browsers
./scripts/pit/run.sh --starters=control-center --headed
  • Keep CC installed in your system so as you can use it later
./scripts/pit/run.sh --starters=control-center --keep-cc

In order to use the kind cluster you will need to forward port 443 to the cluster with sudo

sudo kubectl port-forward -n control-center service/control-center-ingress-nginx-controller 443:443 -n control-center
  • Run the script but using your local docker desktop cluster
./scripts/pit/run.sh --starters=control-center --cluster=docker-desktop

@manolo manolo force-pushed the localization branch 2 times, most recently from 088a48c to 7045273 Compare January 29, 2025 22:45
@manolo manolo force-pushed the localization branch 2 times, most recently from 17c056d to 3b9fdb0 Compare January 30, 2025 10:06
@manolo manolo force-pushed the localization branch 7 times, most recently from cda46d0 to 3e7e509 Compare January 30, 2025 13:58
@manolo manolo force-pushed the localization branch 2 times, most recently from 8eab292 to 6ab8377 Compare January 30, 2025 18:43
@manolo manolo force-pushed the localization branch 4 times, most recently from 4dc9c9f to f3d882a Compare January 30, 2025 23:01
@manolo manolo force-pushed the localization branch 2 times, most recently from 4d887da to 05d3a5f Compare February 1, 2025 12:02
@ZheSun88 ZheSun88 merged commit d00b8e9 into main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants