fix screenshots

vaadin · Jan 30, 2025 · 9f692fb · 9f692fb
1 parent fa48fc6
commit 9f692fb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/scripts/pit/its/cc-identity-management.js b/scripts/pit/its/cc-identity-management.js
@@ -36,8 +36,8 @@ const {log, args, createPage, closePage, takeScreenshot, waitForServerReady, err
     // When app is not running, localization cannot be enabled
     let pageApp = await createPage(arg.headless, true);
     await waitForServerReady(pageApp, url);
+    await takeScreenshot(pageApp, __filename, 'app-running');
     await closePage(pageApp);
-    await takeScreenshot(page, __filename, 'app-running');
 
     log(`Enabling identity Management ...\n`);
     await page.locator('vaadin-select vaadin-input-container div').click();
@@ -114,6 +114,7 @@ const {log, args, createPage, closePage, takeScreenshot, waitForServerReady, err
         await page.getByRole('button', { name: 'Update' }).click();
     } catch (error) {
         err(`Error cleaning up: ${error}\n`);
+        await takeScreenshot(page, __filename, 'error-cleaning');
     }
     await closePage(page);
 })();
diff --git a/scripts/pit/its/cc-localization.js b/scripts/pit/its/cc-localization.js
@@ -40,7 +40,7 @@ const { assert } = require('console');
     const pageApp = await createPage(arg.headless, true);
     await waitForServerReady(pageApp, url);
     await closePage(pageApp);
-    await takeScreenshot(page, __filename, 'app-running');
+    await takeScreenshot(pageApp, __filename, 'app-running');
 
     log(`Uploading and updating localization keys ...\n`);
     await page.locator('vaadin-select vaadin-input-container div').click();
@@ -85,15 +85,15 @@ const { assert } = require('console');
     await page.getByRole('button', { name: 'Start preview' }).click();
     const pagePrev = await createPage(arg.headless, true);
     await waitForServerReady(pagePrev, previewUrl);
-    await takeScreenshot(page, __filename, 'preview-ready');
+    await takeScreenshot(pagePrev, __filename, 'preview-ready');
     const text = await pagePrev.getByText(/Password|Dashboard/).textContent();
     if (text.includes('Password')) {
         await pagePrev.getByLabel('Email').fill(user);
         await pagePrev.getByLabel('Password').fill(password);
         await pagePrev.getByRole('button', {name: 'Sign In'}).click()
         await takeScreenshot(pagePrev, __filename, 'preview-logged-in');
         await expect(pagePrev.getByRole('button', { name: 'New order' })).toBeVisible();
-        await takeScreenshot(page, __filename, 'preview-loaded');
+        await takeScreenshot(pagePrev, __filename, 'preview-loaded');
     }
     // await expect(pagePrev.getByText('Panaderia', { exact: true })).toBeVisible();
     await closePage(pagePrev);
@@ -108,6 +108,7 @@ const { assert } = require('console');
         await page.getByRole('button', { name: 'Update' }).click();
     } catch (error) {
         err(`Error cleaning up: ${error}\n`);
+        await takeScreenshot(page, __filename, 'error-cleaning');
     }
     await closePage(page);
 })();
diff --git a/scripts/pit/lib/lib-ccenter.sh b/scripts/pit/lib/lib-ccenter.sh
@@ -102,7 +102,7 @@ reloadIngress() {
 installTls() {
   [ -n "$SKIPHELM" ] && return 0
   [ -z "$CC_KEY" -o -z "$CC_CERT" ] && log "No CC_KEY and CC_CERT provided, skiping TLS installation" && return 0
-  [ -n "$CC_FULL" ] && CC_CERT="$CC_FULL"
+  # [ -n "$CC_FULL" ] && CC_CERT="$CC_FULL"
   [ -z "$TEST" ] && log "Installing TLS $CC_TLS for $CC_CONTROL and $CC_AUT" || cmd "## Creating TLS file '$CC_DOMAIN.pem' from envs"
   f1=cc-tls.crt
   f2=cc-tls.key

diff --git a/scripts/pit/lib/lib-k8s-kind.sh b/scripts/pit/lib/lib-k8s-kind.sh
@@ -74,7 +74,7 @@ createKindCluster() {
    "kind create cluster --name $1" || return 1
   runCmd "$TEST" "Setting default namespace $2" \
    "kubectl config set-context --current --namespace=$2"
-}
+  }
 
 ##
 # $1: cluster name