Change parallel.status to skip failing tests #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-over-max-length.js
The test is currently failing when updating V8's Node-CI
See: https://bugs.chromium.org/p/v8/issues/detail?id=11570 This PR disables the Proxy test in test/parallel/test-v8-serdes.js while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged. Will do another PR to re-enabled the (fixed) test once the 2739980 has landed.
.. for crrev.com/c/3106647.
Update error message and re-enable test.
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
Merging based on marja@ request.
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. The default implementation of CreateJob will return a nullptr though, so we cannot use it in V8 before Node overrides it.
The CL https://crrev.com/c/3799431 adds a new function to the console object so we need to temporarily disable a repl test that checks for the concrete shape of the console object.
Thanks for the update!
These tests fail on the node-ci builder: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20node.js%20integration%20ng/21832/overview
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
syg
reviewed
Jun 26, 2023
|
Wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the failed tests related to iterator helpers to be able to ship them.