[platform] Override CreateJob instead of PostJob #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. The default implementation of CreateJob will return a nullptr though, so we cannot use it in V8 before Node overrides it.
backes
force-pushed
the
override-create-job
branch
from
b005bfd to
4abb09c
Compare
|
@pthier @victorgomes PTAL |
|
Thanks Clemens! Just for documentation: The interface was changed in https://chromium.googlesource.com/v8/v8.git/+/1e0d18dc0b50a9221fe9955a734905eb918c232c |
victorgomes
pushed a commit
that referenced
this pull request
Aug 11, 2022
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. The default implementation of CreateJob will return a nullptr though, so we cannot use it in V8 before Node overrides it.
pthier
pushed a commit
that referenced
this pull request
Sep 22, 2022
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. The default implementation of CreateJob will return a nullptr though, so we cannot use it in V8 before Node overrides it.
zcbenz
pushed a commit
to photoionization/node_ci
that referenced
this pull request
Apr 17, 2023
To include v8/node#145 Change-Id: I979eb03661856042e5641bf9c6f43ff335d82c37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/3789743 Auto-Submit: Clemens Backes <[email protected]> Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Patrick Thier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostJob will call out to CreateJob in its default implementation, so
it's sufficient to only override CreateJob.
The default implementation of CreateJob will return a nullptr though, so
we cannot use it in V8 before Node overrides it.