Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: routing cannot route DNS over QUIC with IP #1226

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

AkinoKaede
Copy link
Contributor

@AkinoKaede AkinoKaede commented Aug 23, 2021

This Pull Request is inspired by #1144.
I think routing may cannot route DNS over QUIC with IP Address.
Because AdGuard DNS is the only Public DNS that supported DNS over QUIC, and it not supported SNI with IP Address, so I didn't test it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #1226 (d81f40e) into master (c91f98c) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
- Coverage   44.87%   44.75%   -0.13%     
==========================================
  Files         485      484       -1     
  Lines       29505    29479      -26     
==========================================
- Hits        13241    13193      -48     
- Misses      14870    14884      +14     
- Partials     1394     1402       +8     
Impacted Files Coverage Δ
app/dns/nameserver_quic.go 73.95% <100.00%> (ø)
transport/internet/udp/dispatcher.go 64.76% <0.00%> (-12.39%) ⬇️
common/buf/reader.go 82.35% <0.00%> (-5.89%) ⬇️
transport/internet/udp/hub.go 73.61% <0.00%> (-4.17%) ⬇️
proxy/freedom/freedom.go 45.00% <0.00%> (-4.00%) ⬇️
transport/internet/system_listener.go 50.00% <0.00%> (-4.00%) ⬇️
transport/internet/system_dialer.go 46.83% <0.00%> (-2.54%) ⬇️
transport/internet/kcp/listener.go 81.18% <0.00%> (-1.99%) ⬇️
proxy/vmess/outbound/outbound.go 66.36% <0.00%> (-0.91%) ⬇️
transport/internet/sockopt_darwin.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91f98c...d81f40e. Read the comment docs.

@Loyalsoldier Loyalsoldier merged commit 4f9415d into v2fly:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants