fix: routing rule not applied for DNS Server in TCP:// schema #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the problem that routing rule is not applied for DNS Server in TCP:// schema. Related Issue: #1143
Root cause
The
AddressFamily
for theAddress
indest
here is actually a Domain. During Router'sPickRoute
process, it will match against the domain list of the router rule, not the IP list, so the routing rule with IP addresses will never be applied.Fix
use
net.ParseAddress
instead, it will return the right type automatically.(Although the address here is supposed to be IP address).