Another initial fit of HI and LO coils #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-wai
approved these changes
Nov 29, 2020
|
@e-wai uh I don't think I have write access to merge pull requests |
|
It was me... I am unsure of why Emma hasn't merged it, so I deleted that comment. I'll ask Shio/Emma about it. |
|
Waiting to see if Micah Black has a chance to take a look first |
|
Merging but it's imperfect (see outliers and concavity in HI coil graph) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on @e-wai fit on the HI/LO coil data #78
This graphs the efficiency based on purely torque and speed.
Since we won't know current or voltage, its relationship with speed and torque is predicted using the provided data. Thus we can calculate efficiency based on only torque and speed values.
The calculated datapoints don't always match up with the true efficiency, so there are some tweaks that need to be made there...