Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial fit of HI and LO coils, without tests or power draw method. #78

Closed
wants to merge 2 commits into from
Closed

Initial fit of HI and LO coils, without tests or power draw method. #78

wants to merge 2 commits into from

Conversation

e-wai
Copy link
Collaborator

@e-wai e-wai commented Oct 10, 2020 •
edited
Loading

Based on Clarke's work in alt_gain.py and Micah's data here.

  • No tests or power draw so far (for future tickets)
  • I fit it pretty visually... Split into a log func (also tried out power, but didn't work quite as nicely) and the linear section. These aren't super accurate, so I was leaning towards using residuals to keep track of error.

LO Coil
HI Coil

@e-wai e-wai force-pushed the motor-efficiency branch 4 times, most recently from e458e55 to bbf1f7c Compare October 10, 2020 18:48
@e-wai e-wai requested a review from mdshiozaki October 10, 2020 18:54
ufshk
ufshk reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@ufshk ufshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I'm not sure what to add. I think the code is fine?

@e-wai
Copy link
Collaborator Author

e-wai commented Oct 11, 2020

I should run this by Micah Black to make sure I'm representing the graphs correctly.

I'm more trying to figure out if the best way to get the most accurate values is this way?

e-wai
e-wai commented Oct 12, 2020
View reviewed changes
optimization/motor_efficiency.py
- self.linear_func(self.torque[point], self.m, self.b)
for point in range(len(self.torque[6:]))])

def graph(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add axis labels @e-wai

mdshiozaki
mdshiozaki approved these changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@mdshiozaki mdshiozaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out to me

@KristinChengWu KristinChengWu mentioned this pull request Nov 25, 2020
Merged
@e-wai e-wai closed this Dec 2, 2020
@e-wai e-wai deleted the motor-efficiency branch March 24, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufshk ufshk ufshk left review comments

@mdshiozaki mdshiozaki mdshiozaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-wai @mdshiozaki @ufshk