-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(timeout): add benchmarking support with divan #9733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6430915
deps: bump codspeed-divan-compat to v4.2.1
mattsu2020 b196a4d
bench(timeout): add divan benchmarks
mattsu2020 e88a579
ci(benchmarks): include uu_timeout in codspeed list
mattsu2020 9478e1b
Merge branch 'main' into timeout-bench-only-clean
sylvestre c5916df
Merge branch 'main' into timeout-bench-only-clean
mattsu2020 7217b68
Merge branch 'main' into timeout-bench-only-clean
sylvestre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,7 @@ jobs: | |
| uu_shuf, | ||
| uu_sort, | ||
| uu_split, | ||
| uu_timeout, | ||
| uu_tsort, | ||
| uu_unexpand, | ||
| uu_uniq, | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // This file is part of the uutils coreutils package. | ||
| // | ||
| // For the full copyright and license information, please view the LICENSE | ||
| // file that was distributed with this source code. | ||
|
|
||
| #[cfg(unix)] | ||
| use divan::{Bencher, black_box}; | ||
| #[cfg(unix)] | ||
| use uu_timeout::uumain; | ||
| #[cfg(unix)] | ||
| use uucore::benchmark::run_util_function; | ||
|
|
||
| /// Benchmark the fast path where the command exits immediately. | ||
| #[cfg(unix)] | ||
| #[divan::bench] | ||
| fn timeout_quick_exit(bencher: Bencher) { | ||
| bencher.bench(|| { | ||
| black_box(run_util_function(uumain, &["0.02", "true"])); | ||
| }); | ||
| } | ||
|
|
||
| /// Benchmark a command that runs longer than the threshold and receives the default signal. | ||
| #[cfg(unix)] | ||
| #[divan::bench] | ||
| fn timeout_enforced(bencher: Bencher) { | ||
| bencher.bench(|| { | ||
| black_box(run_util_function(uumain, &["0.02", "sleep", "0.2"])); | ||
| }); | ||
| } | ||
|
|
||
| fn main() { | ||
| #[cfg(unix)] | ||
| divan::main(); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.