feat(timeout): add benchmarking support with divan by mattsu2020 · Pull Request #9733 · uutils/coreutils

mattsu2020 · 2025-12-20T05:43:50Z

Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.

related
#9100 (comment)

github-actions · 2025-12-20T07:58:01Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

sylvestre

some jobs are failing

github-actions · 2025-12-22T10:45:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

mattsu2020 · 2025-12-22T11:02:34Z

some jobs are failing

This is a temporary error.

sylvestre · 2025-12-22T12:42:32Z

it seems that divan isn't identifying these new benchmarks

github-actions · 2025-12-22T13:16:37Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

github-actions · 2025-12-23T13:26:15Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

github-actions · 2025-12-24T10:29:05Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-12-26T07:45:21Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

src/uu/timeout/benches/timeout_bench.rs

github-actions · 2025-12-31T00:44:01Z

GNU testsuite comparison:

Congrats! The gnu test tests/cp/preserve-gid is no longer failing!
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-01-14T05:31:04Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/follow-name is no longer failing!

src/uu/timeout/benches/timeout_bench.rs

github-actions · 2026-01-14T08:11:11Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-float is no longer failing!

codspeed-hq · 2026-01-15T11:43:47Z

Merging this PR will not alter performance

✅ 305 untouched benchmarks
🆕 4 new benchmarks
⏩ 46 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
🆕	Simulation	`timeout_quick_exit`	N/A	183.5 µs	N/A
🆕	Simulation	`timeout_enforced`	N/A	83.8 µs	N/A
🆕	Memory	`timeout_quick_exit`	N/A	63 KB	N/A
🆕	Memory	`timeout_enforced`	N/A	19.4 KB	N/A

_{Comparing mattsu2020:timeout-bench-only-clean (7217b68) with main (0260f21)²}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (e406cef) during the generation of this report, so 0260f21 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions · 2026-01-15T11:48:06Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

sylvestre · 2026-01-18T08:52:26Z

still draft, is that expected ?

github-actions · 2026-01-18T11:05:33Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-18T13:32:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

mattsu2020 · 2026-01-18T14:22:51Z

still draft, is that expected ?

The memory investigation for timeout always fails.
This seems to be an issue with CodSpeed memtrack v1.1.0, so this PR cannot be merged for the time being.

github-actions · 2026-01-18T14:23:54Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-20T06:00:19Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/stderr is no longer failing!
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!

github-actions · 2026-01-20T07:44:09Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/stderr is no longer failing!
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!

mattsu2020 · 2026-01-20T12:15:35Z

still draft, is that expected ?

The memory investigation for timeout always fails. This seems to be an issue with CodSpeed memtrack v1.1.0, so this PR cannot be merged for the time being.

Support is now available in codespeed 4.8.0

github-actions · 2026-02-11T12:15:32Z

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

* deps: bump codspeed-divan-compat to v4.2.1 * bench(timeout): add divan benchmarks * ci(benchmarks): include uu_timeout in codspeed list --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

mattsu2020 mentioned this pull request Dec 20, 2025

feat(timeout): add benchmarking support and optimize signal handling #9100

Closed

sylvestre requested changes Dec 22, 2025

View reviewed changes

mattsu2020 requested a review from sylvestre December 26, 2025 07:41

sylvestre reviewed Dec 30, 2025

View reviewed changes

src/uu/timeout/benches/timeout_bench.rs Show resolved Hide resolved

mattsu2020 requested a review from sylvestre January 5, 2026 08:53

sylvestre reviewed Jan 14, 2026

View reviewed changes

src/uu/timeout/benches/timeout_bench.rs Outdated Show resolved Hide resolved

mattsu2020 marked this pull request as draft January 16, 2026 12:39

mattsu2020 added 2 commits January 20, 2026 21:23

deps: bump codspeed-divan-compat to v4.2.1

6430915

bench(timeout): add divan benchmarks

b196a4d

ci(benchmarks): include uu_timeout in codspeed list

e88a579

mattsu2020 force-pushed the timeout-bench-only-clean branch from 02f42a8 to e88a579 Compare January 20, 2026 12:27

mattsu2020 marked this pull request as ready for review January 20, 2026 12:27

mattsu2020 requested a review from sylvestre January 20, 2026 12:27

Merge branch 'main' into timeout-bench-only-clean

9478e1b

mattsu2020 and others added 2 commits March 2, 2026 19:11

Merge branch 'main' into timeout-bench-only-clean

c5916df

Merge branch 'main' into timeout-bench-only-clean

7217b68

sylvestre merged commit 7920971 into uutils:main Apr 4, 2026
167 checks passed

mattsu2020 deleted the timeout-bench-only-clean branch April 4, 2026 22:19

moonfruit mentioned this pull request Apr 7, 2026

uutils-selected 0.8.0 moonfruit/homebrew-tap#518

Closed

Uh oh!

Conversation

mattsu2020 commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

mattsu2020 commented Dec 22, 2025

Uh oh!

sylvestre commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

codspeed-hq bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Performance Changes

Footnotes

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

mattsu2020 commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

mattsu2020 commented Jan 20, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Jan 15, 2026 •

edited

Loading