Skip to content

more: tests: cleanup processes in test_valid_arg #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Aug 6, 2025
Merged

more: tests: cleanup processes in test_valid_arg #8430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff00113
more: tests: cleanup processes in test_valid_arg
martinkunkel2 Aug 4, 2025
e5a2f89
Merge branch 'main' into more-test-fix
martinkunkel2 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions tests/by-util/test_more.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,22 @@ fn test_valid_arg() {

fn test_alive(args: &[&str]) {
let (at, mut ucmd) = at_and_ucmd!();

let content = "test content";
let file = "test_file";
at.touch(file);
at.write(file, content);

let mut cmd = ucmd.args(args).arg(file).run_no_wait();

// wait for more to start and display the file
while cmd.is_alive() && !cmd.stdout_all().contains(content) {
cmd.delay(50);
}

assert!(cmd.is_alive(), "Command should still be alive");

ucmd.args(args)
.arg(file)
.run_no_wait()
.make_assertion()
.is_alive();
// cleanup
cmd.kill();
}

#[test]
Expand Down
Loading