more: tests: cleanup processes in test_valid_arg #8430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cleanup in test_alive to ensure all spawned processes are terminated on successful test execution. This also fixes a race condition that could occur: the check for process is_alive might be executing while more is still parsing the arguments.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the test_alive function in the more utility tests by adding proper process cleanup and fixing a race condition. The changes ensure spawned processes are properly terminated after test execution and add synchronization to wait for the more command to fully start before checking if it's alive.
- Added process cleanup with
cmd.kill()to prevent orphaned processes - Fixed race condition by waiting for
moreto display content before asserting it's alive - Enhanced test setup by writing actual content to the test file instead of just creating an empty file
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cleanup in test_alive to ensure all spawned processes are terminated on successful test execution.
This also fixes a race condition that could occur: the check for process is_alive might be executing while more is still parsing the arguments.
Fixes #8429