Head: ensure stdin input stream is correct on exit #7253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
Author
|
Will un-bork the non-unix build and post an update... |
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
df345cd to
34f2e06
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
34f2e06 to
318e893
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
head_stdio_file
branch
2 times, most recently
from
f48b315 to
3cd59f0
Compare
|
GNU testsuite comparison: |
jfinkels
reviewed
Feb 6, 2025
jfinkels
reviewed
Feb 6, 2025
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
3cd59f0 to
9ee883a
Compare
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
head_stdio_file
branch
from
9ee883a to
01985ac
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
head_stdio_file
branch
3 times, most recently
from
e09cc93 to
bfccf75
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
head_stdio_file
branch
from
bfccf75 to
0995b49
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
0995b49 to
9b6a133
Compare
|
GNU testsuite comparison: |
jfinkels
reviewed
Feb 25, 2025
jfinkels
reviewed
Feb 25, 2025
Collaborator
jfinkels
left a comment
jfinkels
left a comment
There was a problem hiding this comment.
The code itself makes sense, I just have a question about the tests
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
9b6a133 to
0bd9733
Compare
Fix issue uutils#7028 Head tool now ensures that stdin is set to the last character that was output by the tool. This ensures that if any subsequent tools are run from the same input stream they will start at the correct point in the stream.
karlmcdowall
force-pushed
the
head_stdio_file
branch
from
0bd9733 to
ad20cb3
Compare
|
GNU testsuite comparison: |
Collaborator
|
Thank you for your contribution ! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Head tool now ensures that stdin is set to the last character that was output by the tool. This ensures that if any subsequent tools are run from the same input stream they will start at the correct point in the stream.
These changes should fix the head-pos.sh GNU test. This is tracked by issue #7028.