Skip to content

head: Fix bug printing large non-seekable files #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 1 commit into from
Feb 20, 2025
Merged

head: Fix bug printing large non-seekable files #7294

sylvestre merged 1 commit into from
Feb 20, 2025

Conversation

@karlmcdowall
Copy link
Contributor

@karlmcdowall karlmcdowall commented Feb 10, 2025

Fixes issue #7288.
Rewrite logic to print all-but-last-n-bytes in non-seekable files.

@github-actions
Copy link

github-actions bot commented Feb 10, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@karlmcdowall karlmcdowall mentioned this pull request Feb 11, 2025
Closed
@karlmcdowall karlmcdowall marked this pull request as draft February 11, 2025 04:02
@karlmcdowall karlmcdowall marked this pull request as ready for review February 11, 2025 04:34
@karlmcdowall karlmcdowall marked this pull request as draft February 11, 2025 14:33
@karlmcdowall karlmcdowall force-pushed the head_read_but_last_n_bug branch from b970989 to ad0b20d Compare February 11, 2025 17:21
@karlmcdowall karlmcdowall marked this pull request as ready for review February 11, 2025 17:21
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@karlmcdowall karlmcdowall force-pushed the head_read_but_last_n_bug branch from ad0b20d to 3baa9ad Compare February 11, 2025 17:50
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

BenWiederhake
BenWiederhake reviewed Feb 11, 2025
View reviewed changes
@karlmcdowall karlmcdowall force-pushed the head_read_but_last_n_bug branch from 3baa9ad to 77b3cfe Compare February 11, 2025 23:11
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@karlmcdowall karlmcdowall force-pushed the head_read_but_last_n_bug branch from 77b3cfe to 8b19a95 Compare February 12, 2025 03:40
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@karlmcdowall @sylvestre
head: Fix bug printing large non-seekable files
84b42a8 
Fixes issue uutils#7288.
Rewrite logic for print-all-but-last-n-bytes in non-seekable
files.
@sylvestre sylvestre force-pushed the head_read_but_last_n_bug branch from 8b19a95 to 84b42a8 Compare February 12, 2025 09:16
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/rm2 is no longer failing!

@sylvestre sylvestre merged commit 12bb82f into uutils:main Feb 20, 2025
65 checks passed
@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWiederhake BenWiederhake BenWiederhake left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karlmcdowall @BenWiederhake @sylvestre