Introduce Clippy Github Actions #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(don't edit files on the go on iPhone, really doesnt work)
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
|
You will notice some |
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Currently it is broken and we can probably just leave with manually checking clippy output
|
Do you think we need to run clippy on multiple platforms? |
|
I think in particular we need one for Windows as guid feature is a thing I can remove macOS build, but quite honestly currently the build times are not too bad |
|
@KodrAus / @Dylan-DPC this is ready to go |
Dylan-DPC-zz
approved these changes
Oct 28, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Oct 28, 2019
439: Introduce Clippy Github Actions r=Dylan-DPC a=kinggoesgaming **I'm submitting a(n)** other # Description Moves clippy tests over to Github Actions Co-authored-by: Hunar Roop Kahlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) other
Description
Moves clippy tests over to Github Actions