fix: failed to upload OSS with S3 SDK #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojack
approved these changes
Jun 3, 2023
athurg
force-pushed
the
fix_oss_upload_fail_with_s3_sdk
branch
from
2d03615 to
33dc06b
Compare
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #1756.
In #1230 we set an option
HostnameImmutabletotruefor s3 SDK. But it'll break while use this SDK to upload to Aliyun OSS, which is wildly used.Maybe we should split a
OSSbackend storage instead share with S3, but before that, we can fixed this issue ASAP.