feat: add HostnameImmutable to aws endpoint config

[zhaochunqi]

When uploading files without the old config. Server url like "https://minio.test.com" would be converted to "https://bucketname.minio.test.com". For the self-host minio instance, the upload would get errors. With this config enabled, everything would just work perfectly!

some resource related: https://stackoverflow.com/questions/67575681/is-aws-go-sdk-v2-integrated-with-local-minio-server

[github-actions]

Uffizzi Preview deployment-17992 was deleted.

[HappyZ]

I think this relates to my question about using UsePathStyle flag. See https://stackoverflow.com/questions/65953564/issue-with-s3-bucket-naming-policy-and-attempting-to-send-sdk-generated-requests (see updated comment) for counter argument to this change.

[zhaochunqi]

I think this relates to my question about using UsePathStyle flag. See https://stackoverflow.com/questions/65953564/issue-with-s3-bucket-naming-policy-and-attempting-to-send-sdk-generated-requests (see updated comment) for counter argument to this change.

Thanks for the information. That explains why I saw some people here using minio without a problem. Seems like using camelCase won't encounter this problem due to the SDK fallback.

[Zeng1998]

As I said in issue #1176 , in fact, personally, I don't recommend making some changes to the URL style of S3.

[zhaochunqi]

As I said in issue #1176 , in fact, personally, I don't recommend making some changes to the URL style of S3.

Could we make an option for this? For self-hosted minio, it's not necessary to implement urls like bucketname.minio.test.com, and if we do want to use URLs like that for an s3 bucket, we can directly set url like https://bucketname.minio.test.com to the endpoint.

[soheil]

Hey, I've reviewed your code changes, and have some feedback for you:

The added changes looks great, it looks like you've added support for S3-compatible urls for minio!

One suggestion I have is to add comments to explain the code changes. This should help other developers understand what you've done.

Apart from that, I have no further feedback to provide. Keep up the great work!

[zhaochunqi]

In fact, it might be a better choice to add this as an option to the UI. That way, existing configurations won't have problems with it.

[boojack]

LGTM