Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correccion de error en repl cuando se redefinia una variable #319

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

gabrielledezma21
Copy link
Contributor

fix #11

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (a733ac9) to head (bfb2b74).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   89.74%   89.75%           
=======================================
  Files          28       28           
  Lines        3178     3181    +3     
  Branches      577      578    +1     
=======================================
+ Hits         2852     2855    +3     
  Misses        170      170           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielledezma21 buenísimo, te deje un comentario, estaría piola si le agregamos unos chequeos adicionales pero sale con fritas!

test/interpreter.test.ts Show resolved Hide resolved
@fdodino fdodino merged commit 75e485e into master Dec 13, 2024
4 checks passed
@fdodino fdodino deleted the fixRedefinirVariables branch December 13, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

En la consola REPL puedo definir una var y luego una const con el mismo nombre
4 participants