correccion de error en repl cuando se redefinia una variable (#319)

* correccion de error en repl * agregue una verificacion mas * agregue una verificacion mas * Adding more tests and expectations --------- Co-authored-by: Thom <[email protected]> Co-authored-by: Fernando Dodino <[email protected]>
uqbar-project · Dec 13, 2024 · 75e485e · 75e485e
1 parent a733ac9
commit 75e485e
Show file tree

Hide file tree

Showing 2 changed files with 83 additions and 1 deletion.
diff --git a/src/interpreter/runtimeModel.ts b/src/interpreter/runtimeModel.ts
@@ -488,13 +488,19 @@ export class Evaluation {
   }
 
   protected *execVariable(node: Variable): Execution<void> {
+    const variableFullName = targetName(node, node.name)
+
+    if(this.currentFrame.locals.get(variableFullName)){
+      throw new Error('Can\'t redefine a variable')
+    }
+
     const value = yield* this.exec(node.value)
 
     assertNotVoid(value, `Cannot assign to variable '${node.name}': ${getExpressionFor(node.value)} produces no value, cannot assign it to a variable`)
 
     yield node
 
-    this.currentFrame.set(targetName(node, node.name), value)
+    this.currentFrame.set(variableFullName, value)
   }
 
   protected *execAssignment(node: Assignment): Execution<void> {

diff --git a/test/interpreter.test.ts b/test/interpreter.test.ts
@@ -506,6 +506,82 @@ describe('Wollok Interpreter', () => {
         )
       })
 
+      it('Can\'t redefine a const with a var', () => {
+        const replEnvironment = buildEnvironment([{
+          name: REPL, content: `
+            const variableName = 1
+          `,
+        }])
+        interpreter = new Interpreter(Evaluation.build(replEnvironment, WRENatives))
+        const { error } = interprete(interpreter, 'var variableName = 2')
+        assertBasicError(error)
+        expect(getStackTraceSanitized(error)).to.deep.equal(
+          [
+            'wollok.lang.EvaluationError: Error: Can\'t redefine a variable',
+
+          ]
+        )
+        const { result } = interprete(interpreter, 'variableName')
+        expect(+result).to.equal(1)
+      })
+
+      it('Can\'t redefine a const with a const', () => {
+        const replEnvironment = buildEnvironment([{
+          name: REPL, content: `
+            const variableName = 1
+          `,
+        }])
+        interpreter = new Interpreter(Evaluation.build(replEnvironment, WRENatives))
+        const { error } = interprete(interpreter, 'const variableName = 2')
+        assertBasicError(error)
+        expect(getStackTraceSanitized(error)).to.deep.equal(
+          [
+            'wollok.lang.EvaluationError: Error: Can\'t redefine a variable',
+
+          ]
+        )
+        const { result } = interprete(interpreter, 'variableName')
+        expect(+result).to.equal(1)
+      })
+
+      it('Can\'t redefine a var with a const', () => {
+        const replEnvironment = buildEnvironment([{
+          name: REPL, content: `
+            var variableName = 1
+          `,
+        }])
+        interpreter = new Interpreter(Evaluation.build(replEnvironment, WRENatives))
+        const { error } = interprete(interpreter, 'const variableName = 2')
+        assertBasicError(error)
+        expect(getStackTraceSanitized(error)).to.deep.equal(
+          [
+            'wollok.lang.EvaluationError: Error: Can\'t redefine a variable',
+
+          ]
+        )
+        const { result } = interprete(interpreter, 'variableName')
+        expect(+result).to.equal(1)
+      })
+
+      it('Can\'t redefine a var with a var', () => {
+        const replEnvironment = buildEnvironment([{
+          name: REPL, content: `
+            var variableName = 1
+          `,
+        }])
+        interpreter = new Interpreter(Evaluation.build(replEnvironment, WRENatives))
+        const { error } = interprete(interpreter, 'var variableName = 2')
+        assertBasicError(error)
+        expect(getStackTraceSanitized(error)).to.deep.equal(
+          [
+            'wollok.lang.EvaluationError: Error: Can\'t redefine a variable',
+
+          ]
+        )
+        const { result } = interprete(interpreter, 'variableName')
+        expect(+result).to.equal(1)
+      })
+
       it('should wrap void validation errors for assignment to void value', () => {
         const replEnvironment = buildEnvironment([{
           name: REPL, content: `