-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improveSearchBar: centralized the search bar and used the dark theme #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM 🏳️🌈 I'll let @NdibeRaymond merge this. Can you also add a screenshot in the description to show how it looks?
Thanks for making this PR @Jumeb! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment about dirty diffs.
Hello @Jumeb , I noticed you deleted the package-lock.json file. My review about cleaning up dirty diffs wasn't about deleting the package-lock.json file, rather I was talking about returning the package-lock.json to it's initial state before your local dev environment made changes to it. Right now you should just copy the package-lock.json from master branch to your branch and that'd solve the issue. Do this, then let's merge your PR |
Also resolve the conflict in pageWrapperStyles.js and squash your commits into one (this can be done using git rebase then force push. You can read it up) |
improveSearchBar: centralized the search bar and used the dark theme improveSearchBar: centralized the search bar and used the dark theme Delete package-lock.json Removing changes made in the package-lock.json file Revert "Delete package-lock.json" This reverts commit 8cbd267.
@NdibeRaymond thanks for the tips, everyday is an opportunity to learn. I just made the changes and changed the package-lock.json file to its original state. Always had problems with git rebase hope I did it right this time. |
@Jumeb Take a look at latest changes we've merged on http://zubhub.unstructured.studio. The search bar's behavior and UX has changed a bit. Can you adapt to that and rebase in addition to changes @NdibeRaymond requested? Then we can merge this one 👍 |
@Jumeb Also, feel free to fix this current issue with the search category selector in the UI. Should just need to override the |
I’m on it @tuxology and @AndrewLester |
improveSearchBar: centralized the search bar and used the dark theme improveSearchBar: centralized the search bar and used the dark theme Delete package-lock.json Removing changes made in the package-lock.json file Revert "Delete package-lock.json" This reverts commit 8cbd267.
Thanks for the tip, it worked perfectly. I have solved the issues |
@NdibeRaymond Should we merge this one? |
I'll attempt removing the package-lock.json change |
@Jumeb can you try clicking on "allow edits by maintainers" on this PR? the PR made a large change to the package-lock and should be reverted back before merging. |
Sorry for the troubles, I just clicked the option to allow edit by maintainer |
Improvements to search bar.
Centralized for larger devices
dark theme for all devices
Centralized for smaller devices like tables
fixes #177