Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to search bar #177

Closed
3 tasks
srish opened this issue May 26, 2021 · 14 comments · Fixed by #366
Closed
3 tasks

Improvements to search bar #177

srish opened this issue May 26, 2021 · 14 comments · Fixed by #366
Assignees
@Jumeb
Labels
enhancement New feature or request good first issue Good for newcomers low priority

Comments

@srish
Copy link
Member

srish commented May 26, 2021 •
edited
Loading

  • Use darker colored search bar

Screen Shot 2021-05-25 at 8 58 55 PM

  • Center the searchbar on large screens.

Screen Shot 2021-05-25 at 8 59 02 PM

  • Search bar appears funny in mobile view

Screen Shot 2021-05-25 at 8 59 02 PM
@srish srish added the Phase 3 label May 26, 2021
@tuxology tuxology added enhancement New feature or request good first issue Good for newcomers and removed Phase 3 labels Mar 28, 2022
@sunnyside88
Copy link

Hi there, can I work on this issue?

@Jumeb
Copy link
Contributor

Jumeb commented Mar 31, 2022

@tuxology, I would love to work on this issue. Please can you assign it to me

@Jumeb
Copy link
Contributor

Jumeb commented Mar 31, 2022

@tuxology, I would love to work on this issue. Please can you assign it to me

Screenshots

Screenshot from 2022-03-31 22-33-25
dark theme applied

Screenshot from 2022-03-31 22-33-15
Centralized search bar

Screenshot from 2022-03-31 22-35-00
hover effect

I would love to make a pull request @srish and @tuxology

@tuxology
Copy link
Member

If the PR is ready, you can send it @Jumeb Can you adjust he color in 3rd screenshot to be not so dark? Maybe the selected one could be made lighter or light yellow (and icon changed to red?) Play around with it and send the PR

@Jumeb
Copy link
Contributor

Jumeb commented Mar 31, 2022

If the PR is ready, you can send it @Jumeb Can you adjust he color in 3rd screenshot to be not so dark? Maybe the selected one could be made lighter or light yellow (and icon changed to red?) Play around with it and send the PR

Ok on it

@Jumeb
Copy link
Contributor

Jumeb commented Mar 31, 2022

If the PR is ready, you can send it @Jumeb Can you adjust he color in 3rd screenshot to be not so dark? Maybe the selected one could be made lighter or light yellow (and icon changed to red?) Play around with it and send the PR

Ok on it

  • The Icon changes to red, is the original settings from the code, but to give it more contrast I changed it to white.
  • On hover, the search bar become a little bit darker to indicate to the user that an action can occur here on click, so i further reduce the opacity to make it calmer.

@Jumeb Jumeb mentioned this issue Mar 31, 2022
Merged
@Jumeb
Copy link
Contributor

Jumeb commented Mar 31, 2022

@tuxology I just made a pull request, please review the changes.

@tuxology
Copy link
Member

I am reopening this since it seems like changes made in #366 got overwritten by another refactor of code. Apologies @Jumeb 😢 Can you recreate the PR with exact changes and resend it?

@tuxology tuxology reopened this Apr 20, 2022
@Jumeb
Copy link
Contributor

Jumeb commented Apr 21, 2022

I am reopening this since it seems like changes made in #366 got overwritten by another refactor of code. Apologies @Jumeb cry Can you recreate the PR with exact changes and resend it?

Ok, I'm on it.

@srish
Copy link
Member Author

srish commented May 12, 2022

I have added a third bullet item to the task description.

@Ammy198488
Copy link
Contributor

Ammy198488 commented Mar 6, 2023 •
edited
Loading

hello @srish @tuxology I'm interested in working on this.

@iamatifmoin iamatifmoin mentioned this issue Mar 7, 2023
Merged
@iamatifmoin
Copy link
Contributor

@srish @tuxology
I have fixed the issue.
Can you please review the PR?

@ipriyanshi1708
Copy link

Hii @srish @tuxology I am an outreachy applicant, I would love to work on this issue.

@iamatifmoin iamatifmoin mentioned this issue Mar 13, 2023
Merged
@srish
Copy link
Member Author

srish commented Aug 28, 2023

Got fixed it seems.

@srish srish closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jumeb Jumeb

Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improveSearchBar: centralized the search bar and used the dark theme Jumeb/zubhub
7 participants
@srish @tuxology @Jumeb @sunnyside88 @Ammy198488 @ipriyanshi1708 @iamatifmoin