Skip to content

Update Model Conversion Command in save.py to convert_hf_to_gguf.py#730

Merged
danielhanchen merged 2 commits into
unslothai:nightlyfrom
malibayram:main
Jul 4, 2024
Merged

Update Model Conversion Command in save.py to convert_hf_to_gguf.py#730
danielhanchen merged 2 commits into
unslothai:nightlyfrom
malibayram:main

Conversation

@malibayram

Copy link
Copy Markdown
Contributor

Update Model Conversion Command in save.py to convert_hf_to_gguf.py

Description:

This PR updates the model conversion command in save.py to use convert_hf_to_gguf.py, aligning with the latest tools and practices from the llama.cpp repository. This change ensures that the conversion process benefits from the latest efficiency and compatibility improvements.

Changes Made:

  • Replaced the previous model conversion command in save.py with convert_hf_to_gguf.py.

Reason for Change:

  • The file name for the conversion script has been updated in the original llama.cpp repository.
  • Ensures the conversion process is up-to-date with the latest enhancements and compatibility fixes.

Notes:

  • This change requires users to pull the latest changes from the llama.cpp repository to have the convert_hf_to_gguf.py script available.

@danielhanchen danielhanchen changed the base branch from main to nightly July 4, 2024 19:56
@danielhanchen

Copy link
Copy Markdown
Member

Thanks for the fix and appreciate it! I added a few more better error handling methods as well!

I think @sebdg also mentioned about this in our Discord :)

@danielhanchen danielhanchen merged commit a5c7d8d into unslothai:nightly Jul 4, 2024
danielhanchen added a commit that referenced this pull request Jul 4, 2024
* Update mapper.py

* Update Model Conversion Command in `save.py` to `convert_hf_to_gguf.py` (#730)

* Updated convert_hf_to_gguf.py call to align with changes in llama.cpp repository

* Update save.py

---------

Co-authored-by: Daniel Han <danielhanchen@gmail.com>

* Typo Fix (#690)

---------

Co-authored-by: M. Ali Bayram <malibayram91@gmail.com>
Co-authored-by: johnpaulbin <johnpaulbin@gmail.com>
abiswas-realadvice pushed a commit to abiswas-realadvice/unsloth that referenced this pull request May 14, 2026
* Update mapper.py

* Update Model Conversion Command in `save.py` to `convert_hf_to_gguf.py` (unslothai#730)

* Updated convert_hf_to_gguf.py call to align with changes in llama.cpp repository

* Update save.py

---------

Co-authored-by: Daniel Han <danielhanchen@gmail.com>

* Typo Fix (unslothai#690)

---------

Co-authored-by: M. Ali Bayram <malibayram91@gmail.com>
Co-authored-by: johnpaulbin <johnpaulbin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants