Typo Fix#690
Merged
Merged
Conversation
Member
|
Thanks! |
danielhanchen
added a commit
that referenced
this pull request
Jul 4, 2024
* Update mapper.py * Update Model Conversion Command in `save.py` to `convert_hf_to_gguf.py` (#730) * Updated convert_hf_to_gguf.py call to align with changes in llama.cpp repository * Update save.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Typo Fix (#690) --------- Co-authored-by: M. Ali Bayram <malibayram91@gmail.com> Co-authored-by: johnpaulbin <johnpaulbin@gmail.com>
abiswas-realadvice
pushed a commit
to abiswas-realadvice/unsloth
that referenced
this pull request
May 14, 2026
* Update mapper.py * Update Model Conversion Command in `save.py` to `convert_hf_to_gguf.py` (unslothai#730) * Updated convert_hf_to_gguf.py call to align with changes in llama.cpp repository * Update save.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Typo Fix (unslothai#690) --------- Co-authored-by: M. Ali Bayram <malibayram91@gmail.com> Co-authored-by: johnpaulbin <johnpaulbin@gmail.com>
danielhanchen
pushed a commit
to unslothai/unsloth-staging-1
that referenced
this pull request
May 24, 2026
Round 2 of reviewer-driven fixes landed on the PR heads: zoo PR unslothai#684: 0753b115 - merged origin/main (restores unslothai#690 / unslothai#691 gpt-oss eager attn) - cleaned up norm cast monkey patch in train() finally - raise on streaming+dataset_order text combo - VLM baseline CE full-sequence forward parity with CCE - scheduler test now matches HF linear-no-warmup behavior unsloth PR unslothai#5656: bff5b44 (unchanged since last run) Re-fire all three workflows so we get a fresh signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.