Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors training run configuration mapping by extracting it into a shared utility helper (mapTrainingRunConfigOverride) and integrates it into both the historical and live training views. It also adds logic to fetch and display the active run's configuration override in the live training view. A review comment points out a bug in ProgressSection where simplifying the fallback logic causes historical views to incorrectly fall back to the active form state (config) when overrides are undefined, and provides a code suggestion to fix this behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d64b4fd3b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c0631db to
237244b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this in favor of #7217. It overlaps the same Training Progress config surface across the same frontend files, and that newer PR already carries the narrower direction to review. |
2 participants
Problem
The Training Config popover on the Training Progress page can show the mutable form-store config instead of the config for the active training run. History already fetches the selected run record and displays its persisted config, which is why the same run can look correct in History and stale in Current Run.
Change
Share the run-config mapping used by History, fetch the active run record in
LiveTrainingViewwhen a job id is available, and pass that mapped config intoProgressSection.ProgressSectionnow uses the active run override for live runs while keeping live fallback to the form store, and historical runs no longer fall back to unrelated current form state when a saved config field is missing.The active-run fetch keeps retrying transient 404s while the job is starting or running, so the frontend does not give up before the backend has created the
training_runsrow. Permanent 401/403 and completed-run 404s still stop the retry loop.The config mapper now preserves explicit
nullvalues from persisted run records instead of replacing them with mutable store defaults.The change stays in Studio frontend state and rendering code. It does not change backend training, persistence, or run creation.
Testing
cd /d studio/frontend && npm run typecheck && npm run buildProgressSectionoverride precedence,LiveTrainingViewrun-config routing, transient fetch retry cleanup, explicit-null preservation, and history preservationResult: frontend typecheck and build passed after reviewer rework.
Closes #6853