Skip to content

Skip uv check for pre-release bitsanbytes #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinhoyer wants to merge 2 commits into from
Closed

Skip uv check for pre-release bitsanbytes #5019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1df9f1
Skip uv check for pre-release bitsanbytes
martinhoyer Apr 14, 2026
bcc2b83
Merge main: keep uv-based bnb install via UV_SKIP_WHEEL_FILENAME_CHECK
rolandtannous Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,24 +112,18 @@ _install_bnb_rocm() {
_bnb_whl_url=""
;;
esac
# uv rejects the continuous-release_main bitsandbytes wheel because the
# filename version (1.33.7rc0) does not match the embedded metadata version
# (0.50.0.dev0). pip accepts the mismatch, so bootstrap pip and use it.
if ! "$_venv_py" -m pip --version >/dev/null 2>&1; then
if ! run_maybe_quiet "$_venv_py" -m ensurepip --upgrade; then
run_maybe_quiet uv pip install --python "$_venv_py" pip || \
substep "[WARN] could not bootstrap pip; bitsandbytes install will likely fail" "$C_WARN"
fi
fi
if [ -n "$_bnb_whl_url" ]; then
substep "installing bitsandbytes for AMD ROCm (pre-release, PR #1887)..."
if run_install_cmd "$_label (pre-release)" "$_venv_py" -m pip install \
# uv rejects the continuous-release_main wheel because its filename
# version (1.33.7rc0) disagrees with the embedded metadata version
# (0.50.0.dev0); UV_SKIP_WHEEL_FILENAME_CHECK is uv's escape hatch.
if run_install_cmd "$_label (pre-release)" env UV_SKIP_WHEEL_FILENAME_CHECK=1 uv pip install --python "$_venv_py" \

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a supported uv knob to bypass wheel filename checks

UV_SKIP_WHEEL_FILENAME_CHECK=1 is not a recognized uv pip install setting on the supported uv range here (I checked uv pip install --help, and reproduced on uv 0.7.22 that installs still fail with Wheel version does not match filename). Because this script only enforces uv>=0.7.14, the pre-release ROCm wheel path will continue to fail on many valid installations and immediately fall back to PyPI, which this same function documents as still broken for ROCm 4-bit decode.

Useful? React with 👍 / 👎.

@martinhoyer martinhoyer Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it was added in 0.8.23, but that's more of a issue with not bumping up minimal uv version.

--force-reinstall --no-cache-dir --no-deps "$_bnb_whl_url"; then
return 0
fi
substep "[WARN] bnb pre-release install failed; falling back to PyPI (4-bit decode broken on ROCm)" "$C_WARN"
substep "[WARN] bnb pre-release unreachable; falling back to PyPI (4-bit decode broken on ROCm)" "$C_WARN"
fi
run_install_cmd "$_label (pypi fallback)" "$_venv_py" -m pip install \
run_install_cmd "$_label (pypi fallback)" uv pip install --python "$_venv_py" \
--force-reinstall --no-cache-dir --no-deps "bitsandbytes>=0.49.1"
}

Expand Down