Skip uv check for pre-release bitsanbytes#5019
Skip uv check for pre-release bitsanbytes#5019martinhoyer wants to merge 2 commits intounslothai:mainfrom
Conversation
The 'main' wheel version does not match filename (0.50.0.dev0 != 1.33.7rc0).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the install.sh script to include a workaround for a version mismatch error during the installation of bitsandbytes for AMD ROCm. It introduces the UV_SKIP_WHEEL_FILENAME_CHECK=1 environment variable to the uv pip install command to bypass filename validation. I have no feedback to provide.
|
ah, so the #4966 was merged in the meantime. Well, do as you wish with this PR. |
Supersedes the pip-bootstrap approach from unslothai#4966. Drops the ensurepip block and reverts both install paths to uv; UV_SKIP_WHEEL_FILENAME_CHECK handles the continuous-release_main wheel's filename/metadata mismatch without mixing package managers in the studio venv.
|
Pushed a merge of main onto this branch. Dropped the ensurepip bootstrap that came in via #4966 and kept your uv + |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcc2b83cb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # uv rejects the continuous-release_main wheel because its filename | ||
| # version (1.33.7rc0) disagrees with the embedded metadata version | ||
| # (0.50.0.dev0); UV_SKIP_WHEEL_FILENAME_CHECK is uv's escape hatch. | ||
| if run_install_cmd "$_label (pre-release)" env UV_SKIP_WHEEL_FILENAME_CHECK=1 uv pip install --python "$_venv_py" \ |
There was a problem hiding this comment.
UV_SKIP_WHEEL_FILENAME_CHECK=1 is not a recognized uv pip install setting on the supported uv range here (I checked uv pip install --help, and reproduced on uv 0.7.22 that installs still fail with Wheel version does not match filename). Because this script only enforces uv>=0.7.14, the pre-release ROCm wheel path will continue to fail on many valid installations and immediately fall back to PyPI, which this same function documents as still broken for ROCm 4-bit decode.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
well, it was added in 0.8.23, but that's more of a issue with not bumping up minimal uv version.
|
Closing in favor of #4966.
|
2 participants
Workaround for the 'main' wheel version not matching its filename (0.50.0.dev0 != 1.33.7rc0).
Alternative to #4966, which resolves the same issue by not using
uv.