fix: add Python 3.13 constraint to intelgputorch210 extra#4351
fix: add Python 3.13 constraint to intelgputorch210 extra#4351BillionClaw wants to merge 1 commit into
Conversation
The intelgputorch210 extra uses PyTorch 2.10.0 XPU which depends on triton-xpu==3.6.0, but there is no wheel available for Python 3.13. Fixes unslothai#4319
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an installation problem for the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses issue #4319 by adding a Python version constraint to the intelgputorch210 extra in pyproject.toml. This prevents installation failures on Python 3.13 due to the unavailability of a compatible triton-xpu wheel. The changes add ; python_version < '3.13' to the unsloth_zoo[intelgpu] and unsloth[huggingfacenotorch] dependencies within the intelgputorch210 extra.
| "unsloth_zoo[intelgpu] ; python_version < '3.13'", | ||
| "unsloth[huggingfacenotorch] ; python_version < '3.13'", |
There was a problem hiding this comment.
Adding the Python version constraint here is a good approach to prevent installation issues on unsupported Python versions. However, it's crucial to ensure that this constraint is also applied to other dependencies within the intelgputorch210 extra that might also be incompatible with Python 3.13. Neglecting to do so could lead to partial or incomplete installations, which can be difficult to debug. Please review the other dependencies and add the same constraint where applicable.
|
Duplicate of #4337 - closing in favor of the comprehensive fix |
|
Sorry on the delay, we fixed it in #5484. Appreciate the PR again! |
Description
The "intelgputorch210" extra uses PyTorch 2.10.0 XPU which depends on triton-xpu==3.6.0, but there is no wheel available for Python 3.13.
Changes
Related Issue
Fixes #4319