Skip to content

fix: add Python 3.13 constraint to intelgputorch210 extra#4351

Closed
BillionClaw wants to merge 1 commit into
unslothai:mainfrom
BillionClaw:clawoss/fix-python-3.13-intelgputorch210
Closed

fix: add Python 3.13 constraint to intelgputorch210 extra#4351
BillionClaw wants to merge 1 commit into
unslothai:mainfrom
BillionClaw:clawoss/fix-python-3.13-intelgputorch210

Conversation

@BillionClaw

Copy link
Copy Markdown

Description

The "intelgputorch210" extra uses PyTorch 2.10.0 XPU which depends on triton-xpu==3.6.0, but there is no wheel available for Python 3.13.

Changes

  • Added Python version constraint (python_version < '3.13') to dependencies in the intelgputorch210 extra to prevent installation failures on Python 3.13

Related Issue

Fixes #4319

The intelgputorch210 extra uses PyTorch 2.10.0 XPU which depends on triton-xpu==3.6.0, but there is no wheel available for Python 3.13.

Fixes unslothai#4319
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an installation problem for the intelgputorch210 extra when used with Python 3.13. By introducing a version constraint, it ensures that the extra's specific dependencies are only considered for Python versions below 3.13, effectively bypassing compatibility issues with unavailable components.

Highlights

  • Python 3.13 Compatibility: Added a Python version constraint (python_version < '3.13') to the intelgputorch210 extra's dependencies in pyproject.toml. This prevents installation failures on Python 3.13 where required wheels (like triton-xpu) are not yet available.
Changelog
  • pyproject.toml
    • Added Python version constraint (python_version < '3.13') to unsloth_zoo[intelgpu] and unsloth[huggingfacenotorch] within the intelgputorch210 extra.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses issue #4319 by adding a Python version constraint to the intelgputorch210 extra in pyproject.toml. This prevents installation failures on Python 3.13 due to the unavailability of a compatible triton-xpu wheel. The changes add ; python_version < '3.13' to the unsloth_zoo[intelgpu] and unsloth[huggingfacenotorch] dependencies within the intelgputorch210 extra.

Comment thread pyproject.toml
Comment on lines +1022 to +1023
"unsloth_zoo[intelgpu] ; python_version < '3.13'",
"unsloth[huggingfacenotorch] ; python_version < '3.13'",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding the Python version constraint here is a good approach to prevent installation issues on unsupported Python versions. However, it's crucial to ensure that this constraint is also applied to other dependencies within the intelgputorch210 extra that might also be incompatible with Python 3.13. Neglecting to do so could lead to partial or incomplete installations, which can be difficult to debug. Please review the other dependencies and add the same constraint where applicable.

@BillionClaw

Copy link
Copy Markdown
Author

Duplicate of #4337 - closing in favor of the comprehensive fix

@danielhanchen

Copy link
Copy Markdown
Member

Sorry on the delay, we fixed it in #5484. Appreciate the PR again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Install from git -> python3.13

2 participants