fix(intelgputorch210): add missing triton-xpu 3.6.0 wheels#4337
fix(intelgputorch210): add missing triton-xpu 3.6.0 wheels#4337BillionClaw wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical installation issue for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing triton-xpu==3.6.0 dependency for the [intelgputorch210] extra, which is required for torch-2.10.0+xpu. However, this introduces a potential conflict as the old, incorrect pytorch_triton_xpu==3.5.0 dependencies are not removed. My review includes a comment to address this to prevent potential installation issues.
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl#sha256=d133d858d4f2a51f26f36662023ad6efcbfb4b4919b3f15b1fbdfb71cb77700c ; platform_system == 'Linux' and python_version == '3.10' and platform_machine == 'x86_64'", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl#sha256=28f0d5a1ea08dc13f967f4aa31702cb08b561437aaac195f2eb7100721cb5d7f ; platform_system == 'Linux' and python_version == '3.11' and platform_machine == 'x86_64'", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl#sha256=7ba9de96e5d36400b996b9fb9eb38443196453aefc11fafe1a7bb226bc5fb8bb ; platform_system == 'Linux' and python_version == '3.12' and platform_machine == 'x86_64'", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl#sha256=6f68b4193109900080e88f08ee35d5fe27dba0cf7504ebbeec74bfeac066ac95 ; platform_system == 'Linux' and python_version == '3.13' and platform_machine == 'x86_64'", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp310-cp310-win_amd64.whl#sha256=4341e829e54a778ea9d71593bb967d8df4a840e15d247194607ac4d85a516bb8 ; sys_platform == 'win32' and python_version == '3.10' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp311-cp311-win_amd64.whl#sha256=1d4494e959b32ec78ce0dfc389cf68046433624aa7153b4e73dd313431c23c0e ; sys_platform == 'win32' and python_version == '3.11' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp312-cp312-win_amd64.whl#sha256=ea6bdf88f781e12fcd8c0c21ad8b5753282a2e8220e95203138aadf52388330c ; sys_platform == 'win32' and python_version == '3.12' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp313-cp313-win_amd64.whl#sha256=ef733f3dd2a0aa5d33cf8af6f34ea4e1614f3189fe7d76a920f4b1a15d1eee09 ; sys_platform == 'win32' and python_version == '3.13' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", |
There was a problem hiding this comment.
You've correctly added the triton-xpu==3.6.0 dependency required by torch-2.10.0. However, the [intelgputorch210] extra still includes the previous pytorch_triton_xpu==3.5.0 dependency on lines 1025-1032.
Having both of these dependencies will likely cause conflicts. The pytorch_triton_xpu==3.5.0 entries appear to be a leftover from when this section was created and should be removed.
Please remove the block for pytorch_triton_xpu from lines 1025-1032 to ensure only the correct version is installed.
danielhanchen
left a comment
danielhanchen
left a comment
There was a problem hiding this comment.
Review: Right direction, but needs one additional change
This PR correctly fixes the resolver failure from #4319 by adding direct triton-xpu==3.6.0 wheel URLs to intelgputorch210. All 8 added wheel URLs are valid (verified HTTP 200 for each) and the sha256 hashes are correct.
However, the existing pytorch_triton_xpu==3.5.0 entries (lines 1025-1032) must be removed, not kept alongside the new triton-xpu entries.
Why this matters
Both pytorch_triton_xpu and triton-xpu install to the same top-level Python namespace (triton/). pip does not recognize them as alternatives because neither package declares a Provides-Dist: header for the other. With both listed in extras_require, pip resolves and installs both packages. The second one installed silently overwrites the first's files in triton/, leaving a mixed/corrupt environment. Verified by inspecting both wheels: ~392-443 overlapping files in triton/ including triton/__init__.py, triton/_C/libtriton.so, etc.
Additionally, torch-2.10.0+xpu wheel metadata only declares Requires-Dist: triton-xpu==3.6.0 -- it no longer requires pytorch_triton_xpu at all. The pytorch_triton_xpu==3.5.0 entries are a leftover from an older torch XPU build.
Recommended fix
Remove all 8 pytorch_triton_xpu==3.5.0 entries (cp310-cp313, Linux + Windows) and keep only the 8 triton-xpu==3.6.0 entries you added. This is a net-zero line count change (8 removed, 8 added) that:
- Fixes the install failure for all Python versions (3.10-3.13), not just 3.13
- Eliminates the
triton/namespace collision - Preserves Python 3.13 support (all wheels exist)
Regarding PR #4341
PR #4341 should be closed in favor of this PR. That PR removes Python 3.13 support entirely, but:
- The
triton-xpu==3.6.0cp313 wheels do exist at download.pytorch.org - The same install failure affects Python 3.10-3.12 as well (confirmed via
pip --dry-runon 3.12) - Removing cp313 entries turns a hard resolver error into a silent regression where
intelgputorch210no longer provides an XPU stack on Python 3.13
Test evidence
pip install --dry-runonmain: fails withNo matching distribution found for triton-xpu==3.6.0pip install --dry-runon this PR branch: passes, resolver selectstriton-xpu-3.6.0- Installing both triton packages into a throwaway target confirms dual-install:
Successfully installed pytorch-triton-xpu-3.5.0 triton-xpu-3.6.0withtriton.__version__depending on install order
…tries Removes the old pytorch_triton_xpu==3.5.0 dependency entries that conflict with the newer triton-xpu==3.6.0 entries. Addresses review feedback from danielhanchen.
|
Removed the old pytorch_triton_xpu entries as requested. |
|
Done! Removed the 6 "pytorch_triton_xpu==3.5.0" entries. Keeping just the "triton-xpu==3.5.0" entry. Thanks for the review! |
|
Closing - the sha256 hashes don't match the official PyTorch wheel index. Will submit corrected version. |
|
Sorry on the delay, we fixed it in #5484. Appreciate the PR again! |
2 participants
The \[intelgputorch210\] extra provides torch 2.10.0+xpu wheels but was missing the required triton-xpu==3.6.0 dependency that torch requires. This caused installation failures on Python 3.13 (and other versions) when pip could not find a matching triton-xpu distribution.
Added triton-xpu 3.6.0 wheels for Python 3.10-3.13 on both Linux and Windows.
Fixes #4319