Skip to content

fix(trainer): import psutil to prevent NameError in _prepare_dataset #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 2 commits into from
Dec 29, 2025
+3 −0
Merged

fix(trainer): import psutil to prevent NameError in _prepare_dataset #3780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c8b4c4
fix(trainer): import psutil to prevent NameError in _prepare_dataset
alkinun Dec 25, 2025
32b0033
Update rl.py
danielhanchen Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unsloth/models/rl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ def unsloth_prediction_step(
from contextlib import nullcontext
from torch.nn import functional as F
import inspect
import psutil
from transformers import DataCollatorForSeq2Seq, DataCollatorForLanguageModeling as TransformersDataCollatorForLanguageModeling
from transformers.training_args import ParallelMode

Expand Down
1 change: 1 addition & 0 deletions unsloth/tokenizer_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import numpy as np
import gc
import subprocess
import psutil
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding import psutil might fix the NameError as the PR title suggests, psutil does not appear to be used directly in this file. To improve maintainability, it would be better to place the import closer to its usage if possible. If it's used indirectly (e.g., via an exec call), a comment explaining this would be very helpful for future developers.


from unsloth_zoo.tokenizer_utils import (
mean_of_trained_tokens,
Expand Down
1 change: 1 addition & 0 deletions unsloth/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import logging
import os
import psutil
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the other file, psutil is imported here but seems unused within this file's scope. For code clarity and maintainability, please consider moving this import to where psutil is actually called, or add a comment explaining the necessity of this import at the top level.

import warnings
from dataclasses import dataclass, field
from typing import Optional
Expand Down