fix(trainer): import psutil to prevent NameError in _prepare_dataset#3780
Conversation
Summary of ChangesHello @alkinun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds import psutil to two files to fix a reported NameError. While this likely resolves the issue, I've left a couple of comments regarding the placement of these imports to improve code maintainability. It would be great if you could take a look and clarify their usage.
| import numpy as np | ||
| import gc | ||
| import subprocess | ||
| import psutil |
There was a problem hiding this comment.
While adding import psutil might fix the NameError as the PR title suggests, psutil does not appear to be used directly in this file. To improve maintainability, it would be better to place the import closer to its usage if possible. If it's used indirectly (e.g., via an exec call), a comment explaining this would be very helpful for future developers.
|
|
||
| import logging | ||
| import os | ||
| import psutil |
There was a problem hiding this comment.
|
Thanks so much! I added it also to |
Fixes #3777