Skip to content

fix(trainer): import psutil to prevent NameError in _prepare_dataset#3780

Merged
danielhanchen merged 2 commits intounslothai:mainfrom
alkinun:fix-psutil-nameerror-trainer
Dec 29, 2025
Merged

fix(trainer): import psutil to prevent NameError in _prepare_dataset#3780
danielhanchen merged 2 commits intounslothai:mainfrom
alkinun:fix-psutil-nameerror-trainer

Conversation

@alkinun
Copy link
Copy Markdown
Contributor

@alkinun alkinun commented Dec 25, 2025

Fixes #3777

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @alkinun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical NameError by introducing the necessary psutil import statements. This ensures the stability and correct execution of functions that rely on psutil, particularly within the _prepare_dataset context, thereby preventing runtime failures and improving the robustness of the trainer and tokenizer utilities.

Highlights

  • NameError Fix: This pull request resolves a NameError that occurred in the _prepare_dataset function by ensuring the psutil library is correctly imported.
  • psutil Import: The psutil library is now explicitly imported in both unsloth/tokenizer_utils.py and unsloth/trainer.py to make its functionalities available where needed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds import psutil to two files to fix a reported NameError. While this likely resolves the issue, I've left a couple of comments regarding the placement of these imports to improve code maintainability. It would be great if you could take a look and clarify their usage.

import numpy as np
import gc
import subprocess
import psutil
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding import psutil might fix the NameError as the PR title suggests, psutil does not appear to be used directly in this file. To improve maintainability, it would be better to place the import closer to its usage if possible. If it's used indirectly (e.g., via an exec call), a comment explaining this would be very helpful for future developers.


import logging
import os
import psutil
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the other file, psutil is imported here but seems unused within this file's scope. For code clarity and maintainability, please consider moving this import to where psutil is actually called, or add a comment explaining the necessity of this import at the top level.

@danielhanchen
Copy link
Copy Markdown
Contributor

Thanks so much! I added it also to rl.py

@danielhanchen danielhanchen merged commit 3455f02 into unslothai:main Dec 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] NameError: name 'psutil' is not defined in UnslothSFTTrainer._prepare_dataset (Windows environment)

2 participants