Skip to content

Add missing import of inspect #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 2 commits into from
Dec 26, 2025
Merged

Add missing import of inspect #3778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
353750f
Add missing import of inspect
sstamenk Dec 25, 2025
579f102
Update device_type.py
sstamenk Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unsloth/device_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import torch
import functools
import inspect
from unsloth_zoo.utils import Version
Comment on lines 25 to 28
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better code readability and adherence to PEP 8, it's recommended to group and sort imports. Standard library imports should come first, followed by third-party imports, and then local application imports. Each group should be separated by a blank line.

Suggested change
import torch
import functools
import inspect
from unsloth_zoo.utils import Version
import functools
import inspect
import torch
from unsloth_zoo.utils import Version
References
  1. PEP 8 recommends grouping imports in the following order: standard library imports, related third-party imports, and local application/library specific imports. Groups should be separated by a blank line. (link)



Expand Down