Add missing import of inspect#3778
Conversation
Summary of ChangesHello @sstamenk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a crucial fix by adding a missing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing inspect import in unsloth/device_type.py, which is necessary for the code to run without a NameError. I've also suggested reordering the imports in that file to follow PEP 8 guidelines for better maintainability. The change is otherwise good to go.
| import torch | ||
| import functools | ||
| import inspect | ||
| from unsloth_zoo.utils import Version |
There was a problem hiding this comment.
For better code readability and adherence to PEP 8, it's recommended to group and sort imports. Standard library imports should come first, followed by third-party imports, and then local application imports. Each group should be separated by a blank line.
| import torch | |
| import functools | |
| import inspect | |
| from unsloth_zoo.utils import Version | |
| import functools | |
| import inspect | |
| import torch | |
| from unsloth_zoo.utils import Version |
References
- PEP 8 recommends grouping imports in the following order: standard library imports, related third-party imports, and local application/library specific imports. Groups should be separated by a blank line. (link)
|
Oh thank you! |
During the review of #3748 an import of inspect was missed as noticed in #3279
cc @danielhanchen