Skip to content

Add missing import of inspect#3778

Merged
danielhanchen merged 2 commits intounslothai:mainfrom
sstamenk:main
Dec 26, 2025
Merged

Add missing import of inspect#3778
danielhanchen merged 2 commits intounslothai:mainfrom
sstamenk:main

Conversation

@sstamenk
Copy link
Copy Markdown
Contributor

@sstamenk sstamenk commented Dec 25, 2025

During the review of #3748 an import of inspect was missed as noticed in #3279
cc @danielhanchen

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sstamenk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a crucial fix by adding a missing inspect module import to the unsloth/device_type.py file. This oversight was identified in a separate issue and ensures the module has all required dependencies to function correctly, preventing potential runtime errors related to introspection or dynamic object examination.

Highlights

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing inspect import in unsloth/device_type.py, which is necessary for the code to run without a NameError. I've also suggested reordering the imports in that file to follow PEP 8 guidelines for better maintainability. The change is otherwise good to go.

Comment on lines 25 to 28
import torch
import functools
import inspect
from unsloth_zoo.utils import Version
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better code readability and adherence to PEP 8, it's recommended to group and sort imports. Standard library imports should come first, followed by third-party imports, and then local application imports. Each group should be separated by a blank line.

Suggested change
import torch
import functools
import inspect
from unsloth_zoo.utils import Version
import functools
import inspect
import torch
from unsloth_zoo.utils import Version
References
  1. PEP 8 recommends grouping imports in the following order: standard library imports, related third-party imports, and local application/library specific imports. Groups should be separated by a blank line. (link)

@danielhanchen
Copy link
Copy Markdown
Contributor

Oh thank you!

@danielhanchen danielhanchen merged commit a212c17 into unslothai:main Dec 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants