Nightly by danielhanchen · Pull Request #3753 · unslothai/unsloth

danielhanchen · 2025-12-20T03:33:52Z

No description provided.

for more information, see https://pre-commit.ci

@danielhanchen

* Fix get_input_embeds call for VLMs * patch input_require_grads instead * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * cleanup old patch * cleanup old patch * cleanup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestion from @danielhanchen * use logger instead of prints * Move unsloth present set * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com>

for more information, see https://pre-commit.ci

…ightly

for more information, see https://pre-commit.ci

…ightly

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Silence fbgemm TMA print Also safer .push_to_hub * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ightly

for more information, see https://pre-commit.ci

@danielhanchen

* login on token * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * cleanup old code * safer imports * cleanup * Return token after login * correct return types * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestion from @danielhanchen * add back imports * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * finish return token --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com>

* Do not overwrite slots * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

gemini-code-assist · 2025-12-20T03:34:07Z

Summary of Changes

Hello @danielhanchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Hugging Face authentication process within the Unsloth library. By introducing a dedicated hf_login utility function, it centralizes the logic for token retrieval and login attempts. This change enhances code consistency, improves maintainability, and simplifies future updates related to Hugging Face integration across different model loading components.

Highlights

Centralized Hugging Face Login: A new utility function, hf_login, has been introduced in unsloth/models/_utils.py to encapsulate the logic for retrieving Hugging Face tokens and performing login.
Code Refactoring: Existing scattered calls to huggingface_hub.get_token() and huggingface_hub.login() have been replaced with the new hf_login function across various from_pretrained methods in unsloth/models/llama.py, unsloth/models/loader.py, and unsloth/models/vision.py.
Minor Optimization: The __slots__ attribute has been removed from the HidePrintMessage class in unsloth/import_fixes.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the Hugging Face login logic into a new utility function hf_login in unsloth/models/_utils.py. This change centralizes the login process and removes duplicated code from several files, which is a good improvement for maintainability.

My review includes two suggestions:

In unsloth/import_fixes.py, I recommend re-adding __slots__ to the HidePrintMessage class for memory optimization.
In unsloth/models/_utils.py, I suggest replacing a bare except: with a more specific exception to improve error handling robustness.

Overall, this is a positive refactoring with minor areas for improvement.

gemini-code-assist · 2025-12-20T03:35:04Z

unsloth/import_fixes.py

@@ -72,8 +72,6 @@ def filter(self, x):


 class HidePrintMessage:


The __slots__ attribute was removed from the HidePrintMessage class. Using __slots__ is a good practice for memory optimization, especially for classes that are instantiated many times. Since this class has a fixed set of attributes (_original_stream, _hidden_texts), reintroducing __slots__ would be beneficial for performance by preventing the creation of __dict__ for each instance.

class HidePrintMessage: __slots__ = ("_original_stream", "_hidden_texts")

gemini-code-assist · 2025-12-20T03:35:05Z

unsloth/models/_utils.py

+            token = get_token()
+            if token is None:
+                return None
+        except:


Using a bare except: is generally discouraged as it can catch unexpected errors like SystemExit or KeyboardInterrupt, making the program harder to debug and control. It's better to catch a more specific exception, like Exception, or even more specific ones like ImportError or huggingface_hub.utils.HfHubError if applicable.

Suggested change

except:

except Exception:

danielhanchen and others added 30 commits December 9, 2025 01:02

Update _utils.py

e53e185

Merge branch 'main' into nightly

150eadf

Merge branch 'main' into nightly

25a6250

Merge branch 'main' into nightly

6b908cf

Merge branch 'main' into nightly

f754bd2

[pre-commit.ci] auto fixes from pre-commit.com hooks

30ade52

for more information, see https://pre-commit.ci

Merge branch 'main' into nightly

94bbcaa

Merge branch 'main' into nightly

30b78c5

Merge branch 'main' into nightly

f357fc5

Merge branch 'main' into nightly

a63a337

Update rope_embedding.py

2c22ce6

Merge branch 'main' into nightly

449430d

Fixes

b5f1a77

Update _utils.py

c94f595

Update import_fixes.py

01319d3

Update rl_replacements.py

696a540

fix_openenv_no_vllm

ac54d6e

Fix

9a98139

Update __init__.py

680f19f

Update __init__.py

fb763f3

Update __init__.py

f4f2a7f

Update import_fixes.py

e17b62f

Update import_fixes.py

f34eb0a

Update import_fixes.py

04ad21c

logger

32b52a0

Update __init__.py

0c9288f

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5b57b3

for more information, see https://pre-commit.ci

Update __init__.py

efb5801

Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…

12ccc47

…ightly

danielhanchen and others added 27 commits December 16, 2025 19:49

Update __init__.py

4c80b03

Update import_fixes.py

e57edc2

Update import_fixes.py

9bc1567

Update import_fixes.py

c22fbb7

Update import_fixes.py

d7482e8

[pre-commit.ci] auto fixes from pre-commit.com hooks

ca77798

for more information, see https://pre-commit.ci

Update import_fixes.py

71c5938

Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…

2991a7d

…ightly

Update unsloth/import_fixes.py

7c10195

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Merge branch 'main' into nightly

7f744d9

Merge branch 'main' into nightly

d96ac97

Update save.py

3738db7

Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…

6e5a561

…ightly

Update loader.py

3e6cfb5

Update save.py

30a454c

Update save.py

b58663a

Update _utils.py

7b61375

Update _utils.py

a2b5def

Diffusers warnings

59a1fa5

Update pyproject.toml

5e33a07

[pre-commit.ci] auto fixes from pre-commit.com hooks

1f1bf49

for more information, see https://pre-commit.ci

Merge branch 'main' into nightly

0ed6738

Merge branch 'main' into nightly

6346d17

Do not overwrite slots (#3752)

1de77bf

* Do not overwrite slots * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Merge branch 'main' into nightly

4d99c57

gemini-code-assist bot reviewed Dec 20, 2025

View reviewed changes

danielhanchen merged commit 20adb44 into main Dec 20, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nightly#3753

Nightly#3753
danielhanchen merged 60 commits intomainfrom
nightly

danielhanchen commented Dec 20, 2025

Uh oh!

gemini-code-assist bot commented Dec 20, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 20, 2025

Uh oh!

gemini-code-assist bot Dec 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -72,8 +72,6 @@ def filter(self, x):


		class HidePrintMessage:

Uh oh!

Conversation

danielhanchen commented Dec 20, 2025

Uh oh!

gemini-code-assist bot commented Dec 20, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants