[fbgemm] Silence tma fbgemm

[Datta0]

We now would have the flexibility of silencing print statements as well along with loggers.
NOTE: If in future we want to do selective filtering based on UNSLOTH_ENABLE_LOGGING we can do that as well with slight modifications

[gemini-code-assist]

Summary of Changes

Hello @Datta0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the system's output management and bolstering code robustness. It implements a flexible new mechanism to suppress specific print statements, particularly addressing verbose logging from FBGEMM. Additionally, it introduces a defensive check to prevent errors when dynamically patching model saving functions, ensuring that attributes are present before being accessed.

Highlights

• Print Statement Silencing: Introduced a new HidePrintMessage class to intercept and filter messages written to sys.stderr, providing granular control over console output.
• FBGEMM Output Control: Specifically configured the new filtering mechanism to silence the 'TMA benchmarks will be running' message originating from FBGEMM, improving output clarity when logging is not explicitly enabled.
• Robustness for push_to_hub: Enhanced the patch_saving_functions by adding a hasattr check before accessing the push_to_hub.__name__ attribute, preventing potential AttributeErrors if the attribute is missing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to silence print statements directed to sys.stderr, specifically to hide a verbose message from FBGEMM. This is achieved by conditionally monkey-patching sys.stderr with a custom proxy class. Additionally, a small robustness fix is included in unsloth/save.py to prevent an AttributeError by adding a hasattr check. The changes are generally good, and my feedback focuses on improving the robustness of the new proxy class for sys.stderr to better handle more complex stream interactions in the future.

[gemini-code-assist]

The current proxy implementation for sys.stderr is effective for simple print statements but lacks completeness. It doesn't implement the full file-like object interface, which can lead to a TypeError if other code expects sys.stderr to be iterable (e.g., for line in sys.stderr:).

Adding an __iter__ method would make the proxy more robust against such cases without affecting existing functionality, ensuring better compatibility with libraries that might interact with stderr in more advanced ways.

Suggested change

	def flush(self):
	self._original_stream.flush()
	def __getattr__(self, name):
	def flush(self):
	self._original_stream.flush()
	def __iter__(self):
	return iter(self._original_stream)
	def __getattr__(self, name):
	return getattr(self._original_stream, name)

[nikitml]

Please consider #3745