-
-
Notifications
You must be signed in to change notification settings - Fork 156
fix(nuxt): inject types for nuxt 4 too (+ add nuxt 4 example) #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ example/README.md | |
| .nuxt | ||
| .idea | ||
| .svelte-kit/ | ||
| examples/nuxt3/pnpm-lock.yaml | ||
| examples/nuxt4/pnpm-lock.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # Nuxt Minimal Starter | ||
|
|
||
| Look at the [Nuxt documentation](https://nuxt.com/docs/getting-started/introduction) to learn more. | ||
|
|
||
| ## Setup | ||
|
|
||
| Make sure to install dependencies: | ||
|
|
||
| ```bash | ||
| # npm | ||
| npm install | ||
|
|
||
| # pnpm | ||
| pnpm install | ||
|
|
||
| # yarn | ||
| yarn install | ||
|
|
||
| # bun | ||
| bun install | ||
| ``` | ||
|
|
||
| ## Development Server | ||
|
|
||
| Start the development server on `http://localhost:3000`: | ||
|
|
||
| ```bash | ||
| # npm | ||
| npm run dev | ||
|
|
||
| # pnpm | ||
| pnpm dev | ||
|
|
||
| # yarn | ||
| yarn dev | ||
|
|
||
| # bun | ||
| bun run dev | ||
| ``` | ||
|
|
||
| ## Production | ||
|
|
||
| Build the application for production: | ||
|
|
||
| ```bash | ||
| # npm | ||
| npm run build | ||
|
|
||
| # pnpm | ||
| pnpm build | ||
|
|
||
| # yarn | ||
| yarn build | ||
|
|
||
| # bun | ||
| bun run build | ||
| ``` | ||
|
|
||
| Locally preview production build: | ||
|
|
||
| ```bash | ||
| # npm | ||
| npm run preview | ||
|
|
||
| # pnpm | ||
| pnpm preview | ||
|
|
||
| # yarn | ||
| yarn preview | ||
|
|
||
| # bun | ||
| bun run preview | ||
| ``` | ||
|
|
||
| Check out the [deployment documentation](https://nuxt.com/docs/getting-started/deployment) for more information. |
File renamed without changes.
3 changes: 2 additions & 1 deletion
3
examples/nuxt3/components.d.ts → examples/nuxt4/app/components.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| // https://nuxt.com/docs/guide/concepts/typescript | ||
| "files": [], | ||
| "references": [ | ||
| { | ||
| "path": "./.nuxt/tsconfig.app.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.server.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.shared.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.node.json" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| packages: | ||
| - 'examples/*' | ||
| - '!examples/nuxt3' | ||
| - '!examples/nuxt4' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Nuxt3 and Nuxt4 is basically the same, I don't think we need to keep two versions in the examples. We could just rename the folder and bump the deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted the nuxt 3 folder