Skip to content

Conversation

@MiniDigger
Copy link
Contributor

@MiniDigger MiniDigger commented Jul 19, 2025

Description

make sure to inject types into projects that use the newly released nuxt 4.

Linked Issues

didn't bother to open one. you can revert the change and run pnpm run typecheck to see the (vue-)tsc error

Additional context

not sure if there is a better way to make this check, maybe parse it as it and assert > 2 or something? nuxt 5 isnt thaaaat far away (but also easy enough to fix).
also not sure if a nuxt 4 example was worth but, but I figured since the dir structure is different it might be a good idea.

for anyone running into this too: you can manually add the types to your nuxt config for now:

typescript: {
  tsConfig: {
    compilerOptions: {
      types: ["unplugin-icons/types/vue"],
    }
  }
}

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@socket-security
Copy link

socket-security bot commented Jul 19, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

.idea
.svelte-kit/
examples/nuxt3/pnpm-lock.yaml
examples/nuxt4/pnpm-lock.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Nuxt3 and Nuxt4 is basically the same, I don't think we need to keep two versions in the examples. We could just rename the folder and bump the deps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted the nuxt 3 folder

@socket-security
Copy link

socket-security bot commented Jul 28, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@antfu antfu merged commit ebd026f into unplugin:main Jul 29, 2025
2 checks passed
@MiniDigger MiniDigger deleted the fix/nuxt4-types branch August 1, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants